Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Nick Desaulniers
On Mon, Oct 12, 2020 at 8:10 AM Guillaume Tucker wrote: > > On 12/10/2020 15:40, Willy Tarreau wrote: > > On Mon, Oct 12, 2020 at 04:32:12PM +0200, Borislav Petkov wrote: > >> On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: > >>> However, it was found while adding some x86

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 04:10:45PM +0100, Guillaume Tucker wrote: > You can get serial console on recent enough Chromebooks with a > debug interface such as SuzyQable: > > https://www.sparkfun.com/products/14746 > > It's not a USB Type-C adapter, it has a debug interface which > works with

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 04:40:40PM +0200, Willy Tarreau wrote: > Well, to be precise, they don't have *anymore*. I used to exclusively > select laptops having a serial port given that I was using it daily with > routers, until I had to resign when I abandonned my good old NC8000 :-/ Yah, with all

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Guillaume Tucker
On 12/10/2020 15:40, Willy Tarreau wrote: > On Mon, Oct 12, 2020 at 04:32:12PM +0200, Borislav Petkov wrote: >> On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: >>> However, it was found while adding some x86 Chromebooks[1] to >>> KernelCI that x86_64_defconfig lacked some basic

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Willy Tarreau
On Mon, Oct 12, 2020 at 04:32:12PM +0200, Borislav Petkov wrote: > On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: > > However, it was found while adding some x86 Chromebooks[1] to > > KernelCI that x86_64_defconfig lacked some basic things for > > anyone to be able to boot a

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Borislav Petkov
On Mon, Oct 12, 2020 at 11:22:10AM +0100, Guillaume Tucker wrote: > However, it was found while adding some x86 Chromebooks[1] to > KernelCI that x86_64_defconfig lacked some basic things for > anyone to be able to boot a kernel with a serial console enabled > on those. Hold on, those are

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-12 Thread Guillaume Tucker
On 12/10/2020 04:58, Willy Tarreau wrote: > Hi Enric, > > On Sun, Oct 11, 2020 at 07:05:55PM +0200, Enric Balletbo i Serra wrote: >> For arm64 (i.e : arm64_defconfig): >> 1. Someone renames CONFIG_A to CONFIG_AB, sends a patch, and as he did a >> grep, the patch modifies all the defconfigs.

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Willy Tarreau
Hi Enric, On Sun, Oct 11, 2020 at 07:05:55PM +0200, Enric Balletbo i Serra wrote: > For arm64 (i.e : arm64_defconfig): > 1. Someone renames CONFIG_A to CONFIG_AB, sends a patch, and as he did a > grep, the patch modifies all the defconfigs. > 2. The patch is accepted and merged in

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Borislav Petkov
On Sun, Oct 11, 2020 at 07:05:55PM +0200, Enric Balletbo i Serra wrote: > For x86: >1. You send a patch to list enabling the CONFIG_YOUR_V4L2_DEVICE=m >2. The patch is rejected because doesn't fit the requirements (is not > common > enough) Well, what if that config option enables

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 17:57, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote: >> How do you quantify those things are NOT common enough? Do you have a number? > > I don't want to change the defconfig - you do. So quantifying is in your > court -

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Borislav Petkov
On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote: > How do you quantify those things are NOT common enough? Do you have a number? I don't want to change the defconfig - you do. So quantifying is in your court - not mine. > I don't have a number, the only I can tell is that

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 14:20, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 01:43:44PM +0200, Enric Balletbo i Serra wrote: >> We're also probably lacking a definition of what normal users mean, because I >> don't think normal users build their own kernel. > > You'd be surprised. > >> I

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Borislav Petkov
On Sun, Oct 11, 2020 at 01:43:44PM +0200, Enric Balletbo i Serra wrote: > We're also probably lacking a definition of what normal users mean, because I > don't think normal users build their own kernel. You'd be surprised. > I think that at least X86_AMD_PLATFORM_DEVICE and MFD_INTEL_LPSS_PCI >

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav and Randy, Thank you for your comments. On 8/10/20 20:31, Randy Dunlap wrote: > On 10/8/20 9:40 AM, Borislav Petkov wrote: >> On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: >>> As part of KernelCI, we added a bunch of different x86 based Chromebooks >>> to do

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-08 Thread Randy Dunlap
On 10/8/20 9:40 AM, Borislav Petkov wrote: > On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: >> As part of KernelCI, we added a bunch of different x86 based Chromebooks >> to do test booting and runtime testing. It will be useful have serial >> support for these platforms

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-08 Thread Borislav Petkov
On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: > As part of KernelCI, we added a bunch of different x86 based Chromebooks > to do test booting and runtime testing. It will be useful have serial > support for these platforms in the default defconfig, as this, is the >

[PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-08 Thread Enric Balletbo i Serra
As part of KernelCI, we added a bunch of different x86 based Chromebooks to do test booting and runtime testing. It will be useful have serial support for these platforms in the default defconfig, as this, is the defconfig used by default for the different maintainer's tree. SERIAL_8250_DW is the