Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread Thomas Gleixner
On Thu, 15 Nov 2007, David P. Reed wrote: > There are a couple of things I don't understand on this one. And I presume > you thought the other two bug fixing patches I sent before this were OK to go, > since on my system I had to fix up all of them. > Thomas Gleixner wrote: > > > Still

Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread David P. Reed
There are a couple of things I don't understand on this one. And I presume you thought the other two bug fixing patches I sent before this were OK to go, since on my system Thomas Gleixner wrote: Still whitespace wreckage in your patches. I guess the kernel tree you made your patches

Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread Thomas Gleixner
On Wed, 14 Nov 2007, David P. Reed wrote: Still whitespace wreckage in your patches. I guess the kernel tree you made your patches against is already white space wrecked. I fixed that up manually, but please be more careful about that next time. > Correct potentially unstable PC RTC time

Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread Thomas Gleixner
On Wed, 14 Nov 2007, David P. Reed wrote: Still whitespace wreckage in your patches. I guess the kernel tree you made your patches against is already white space wrecked. I fixed that up manually, but please be more careful about that next time. Correct potentially unstable PC RTC time

Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread David P. Reed
There are a couple of things I don't understand on this one. And I presume you thought the other two bug fixing patches I sent before this were OK to go, since on my system Thomas Gleixner wrote: Still whitespace wreckage in your patches. I guess the kernel tree you made your patches

Re: [PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-15 Thread Thomas Gleixner
On Thu, 15 Nov 2007, David P. Reed wrote: There are a couple of things I don't understand on this one. And I presume you thought the other two bug fixing patches I sent before this were OK to go, since on my system I had to fix up all of them. Thomas Gleixner wrote: Still whitespace

[PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-14 Thread David P. Reed
Correct potentially unstable PC RTC time register reading in time_64.c Stop the use of an incorrect technique for reading the standard PC RTC timer, which is documented to "disconnect" time registers from the bus while updates are in progress. The use of UIP flag while interrupts are disabled

[PATCH] x86: on x86_64, correct reading of PC RTC when update in progress in time_64.c

2007-11-14 Thread David P. Reed
Correct potentially unstable PC RTC time register reading in time_64.c Stop the use of an incorrect technique for reading the standard PC RTC timer, which is documented to disconnect time registers from the bus while updates are in progress. The use of UIP flag while interrupts are disabled to