Re: [PATCH -next v2] mailbox: zynqmp-ipi: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()

2020-04-29 Thread Markus Elfring
> So we should check whether the return value of devm_ioremap() > is NULL instead of IS_ERR. Will an other change description provide the preferred imperative wording?

[PATCH -next v2] mailbox: zynqmp-ipi: Fix NULL vs IS_ERR() check in zynqmp_ipi_mbox_probe()

2020-04-29 Thread Wei Yongjun
In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). So we should check whether the return value of devm_ioremap() is NULL instead of IS_ERR. Fixes: 4981b82ba2ff ("mailbox: ZynqMP IPI mailbox controller") Signed-off-by: Wei Yongjun --- v1 ->v2: fix the description