Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-08-05 Thread Vineet Gupta
On 7/30/20 12:50 AM, Herbert Xu wrote: > On Thu, Jul 30, 2020 at 10:47:16AM +0300, Andy Shevchenko wrote: >> We may ask Synopsys folks to look at this as well. >> Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? > I don't think there is any technical difficulty. The

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-30 Thread Andy Shevchenko
On Thu, Jul 30, 2020 at 10:51 AM Herbert Xu wrote: > On Thu, Jul 30, 2020 at 10:47:16AM +0300, Andy Shevchenko wrote: > > > > We may ask Synopsys folks to look at this as well. > > Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? > > I don't think there is any technical

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-30 Thread Herbert Xu
On Thu, Jul 30, 2020 at 10:47:16AM +0300, Andy Shevchenko wrote: > > We may ask Synopsys folks to look at this as well. > Vineet, any ideas if we may unify ATOMIC64_INIT() across the architectures? I don't think there is any technical difficulty. The custom atomic64_t simply adds an alignment

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-30 Thread Andy Shevchenko
On Thu, Jul 30, 2020 at 4:00 AM Herbert Xu wrote: > > On Wed, Jul 29, 2020 at 06:04:57PM +0300, Andy Shevchenko wrote: > > On Wed, Jul 29, 2020 at 4:35 PM Waiman Long wrote: > > > On 7/29/20 8:28 AM, Herbert Xu wrote: > > > > ... > > > > > This patch series looks good to me. I just wonder if we

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Herbert Xu
On Wed, Jul 29, 2020 at 06:04:57PM +0300, Andy Shevchenko wrote: > On Wed, Jul 29, 2020 at 4:35 PM Waiman Long wrote: > > On 7/29/20 8:28 AM, Herbert Xu wrote: > > ... > > > This patch series looks good to me. I just wonder if we should also move > > ATOMIC64_INIT() to types.h for symmetry

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Sergey Senozhatsky
On (20/07/29 22:28), Herbert Xu wrote: > This miniseries breaks a header loop involving qspinlock_types.h. > The issue is that qspinlock_types.h includes atomic.h, which then > eventually includes kernel.h which could lead back to the original > file via spinlock_types.h. > > The first patch

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Sergey Senozhatsky
On (20/07/29 16:28), pet...@infradead.org wrote: > On Wed, Jul 29, 2020 at 10:28:49PM +0900, Sergey Senozhatsky wrote: > > On (20/07/29 15:00), pet...@infradead.org wrote: > > > On Wed, Jul 29, 2020 at 10:51:44PM +1000, Herbert Xu wrote: > > > > On Wed, Jul 29, 2020 at 02:47:44PM +0200,

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Andy Shevchenko
On Wed, Jul 29, 2020 at 4:35 PM Waiman Long wrote: > On 7/29/20 8:28 AM, Herbert Xu wrote: ... > This patch series looks good to me. I just wonder if we should also move > ATOMIC64_INIT() to types.h for symmetry purpose. Anyway, Same question here. -- With Best Regards, Andy Shevchenko

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 10:28:49PM +0900, Sergey Senozhatsky wrote: > On (20/07/29 15:00), pet...@infradead.org wrote: > > On Wed, Jul 29, 2020 at 10:51:44PM +1000, Herbert Xu wrote: > > > On Wed, Jul 29, 2020 at 02:47:44PM +0200, pet...@infradead.org wrote: > > > > > [..] > > > > Anyway, the

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Waiman Long
On 7/29/20 8:28 AM, Herbert Xu wrote: This miniseries breaks a header loop involving qspinlock_types.h. The issue is that qspinlock_types.h includes atomic.h, which then eventually includes kernel.h which could lead back to the original file via spinlock_types.h. The first patch moves

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Sergey Senozhatsky
On (20/07/29 15:00), pet...@infradead.org wrote: > On Wed, Jul 29, 2020 at 10:51:44PM +1000, Herbert Xu wrote: > > On Wed, Jul 29, 2020 at 02:47:44PM +0200, pet...@infradead.org wrote: > > > [..] > > > Anyway, the patches look sane enough, I'll go stick them in > > > tip/locking/core or somesuch.

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 10:51:44PM +1000, Herbert Xu wrote: > On Wed, Jul 29, 2020 at 02:47:44PM +0200, pet...@infradead.org wrote: > > > > How did you run into this, I haven't seen any build failures due to > > this. > > I didn't, Stephen ran into it after merging the printk tree together > with

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Herbert Xu
On Wed, Jul 29, 2020 at 02:47:44PM +0200, pet...@infradead.org wrote: > > How did you run into this, I haven't seen any build failures due to > this. I didn't, Stephen ran into it after merging the printk tree together with the powerpc tree:

Re: [PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread peterz
On Wed, Jul 29, 2020 at 10:28:07PM +1000, Herbert Xu wrote: > This miniseries breaks a header loop involving qspinlock_types.h. > The issue is that qspinlock_types.h includes atomic.h, which then > eventually includes kernel.h which could lead back to the original > file via spinlock_types.h. How

[PATCH 0/2] locking/qspinlock: Break qspinlock_types.h header loop

2020-07-29 Thread Herbert Xu
This miniseries breaks a header loop involving qspinlock_types.h. The issue is that qspinlock_types.h includes atomic.h, which then eventually includes kernel.h which could lead back to the original file via spinlock_types.h. The first patch moves ATOMIC_INIT into linux/types.h while the second