Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-23 Thread Greg Ungerer
Hi Michael, On 12/21/2012 08:46 PM, Michel Lespinasse wrote: > I wanted to ask if you could check the sanity of the following patches > in nommu configurations. My understanding is that these always > populate mappings when they are created, so that MAP_POPULATE and > MAP_LOCKED are actually

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-23 Thread Greg Ungerer
Hi Michael, On 12/21/2012 08:46 PM, Michel Lespinasse wrote: I wanted to ask if you could check the sanity of the following patches in nommu configurations. My understanding is that these always populate mappings when they are created, so that MAP_POPULATE and MAP_LOCKED are actually no-ops.

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-04 Thread Michel Lespinasse
On Fri, Jan 4, 2013 at 10:16 AM, Andy Lutomirski wrote: > I still have quite a few instances of 2-6 ms of latency due to > "call_rwsem_down_read_failed __do_page_fault do_page_fault > page_fault". Any idea why? I don't know any great way to figure out > who is holding mmap_sem at the time.

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-04 Thread Andy Lutomirski
On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wrote: > We have many vma manipulation functions that are fast in the typical case, > but can optionally be instructed to populate an unbounded number of ptes > within the region they work on: > - mmap with MAP_POPULATE or MAP_LOCKED flags; > -

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-04 Thread Andy Lutomirski
On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wal...@google.com wrote: We have many vma manipulation functions that are fast in the typical case, but can optionally be instructed to populate an unbounded number of ptes within the region they work on: - mmap with MAP_POPULATE or MAP_LOCKED

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-04 Thread Michel Lespinasse
On Fri, Jan 4, 2013 at 10:16 AM, Andy Lutomirski l...@amacapital.net wrote: I still have quite a few instances of 2-6 ms of latency due to call_rwsem_down_read_failed __do_page_fault do_page_fault page_fault. Any idea why? I don't know any great way to figure out who is holding mmap_sem at

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-03 Thread Andy Lutomirski
On Sat, Dec 22, 2012 at 1:37 AM, Michel Lespinasse wrote: > On Fri, Dec 21, 2012 at 6:16 PM, Andy Lutomirski wrote: >> On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wrote: >>> Could you share your test case so I can try reproducing the issue >>> you're seeing ? >> >> Not so easy. My test

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2013-01-03 Thread Andy Lutomirski
On Sat, Dec 22, 2012 at 1:37 AM, Michel Lespinasse wal...@google.com wrote: On Fri, Dec 21, 2012 at 6:16 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wal...@google.com wrote: Could you share your test case so I can try reproducing the issue

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-22 Thread Greg Ungerer
Hi Michel, On 12/21/2012 08:46 PM, Michel Lespinasse wrote: I wanted to ask if you could check the sanity of the following patches in nommu configurations. My understanding is that these always Sure. I think it is worth CC'ing David Howells on these as well, he has spent a fair bit of time in

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-22 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 6:16 PM, Andy Lutomirski wrote: > On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wrote: >> Could you share your test case so I can try reproducing the issue >> you're seeing ? > > Not so easy. My test case is a large chunk of a high-frequency > trading system :)

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-22 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 6:16 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wal...@google.com wrote: Could you share your test case so I can try reproducing the issue you're seeing ? Not so easy. My test case is a large chunk of a

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-22 Thread Greg Ungerer
Hi Michel, On 12/21/2012 08:46 PM, Michel Lespinasse wrote: I wanted to ask if you could check the sanity of the following patches in nommu configurations. My understanding is that these always Sure. I think it is worth CC'ing David Howells on these as well, he has spent a fair bit of time in

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wrote: > On Fri, Dec 21, 2012 at 5:09 PM, Andy Lutomirski wrote: >> On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wrote: >>> On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski >>> wrote: Something's buggy here. My evil test case is

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 5:09 PM, Andy Lutomirski wrote: > On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wrote: >> On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski wrote: >>> Something's buggy here. My evil test case is stuck with lots of >>> threads spinning at 100% system time. >>> >>>

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wrote: > On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski wrote: >> On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wrote: >>> We have many vma manipulation functions that are fast in the typical case, >>> but can optionally be instructed to

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski wrote: > On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wrote: >> We have many vma manipulation functions that are fast in the typical case, >> but can optionally be instructed to populate an unbounded number of ptes >> within the region they

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wrote: > We have many vma manipulation functions that are fast in the typical case, > but can optionally be instructed to populate an unbounded number of ptes > within the region they work on: > - mmap with MAP_POPULATE or MAP_LOCKED flags; > -

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
Hi Greg, I wanted to ask if you could check the sanity of the following patches in nommu configurations. My understanding is that these always populate mappings when they are created, so that MAP_POPULATE and MAP_LOCKED are actually no-ops. Is this an accurate description ? Thanks, On Thu, Dec

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
Hi Greg, I wanted to ask if you could check the sanity of the following patches in nommu configurations. My understanding is that these always populate mappings when they are created, so that MAP_POPULATE and MAP_LOCKED are actually no-ops. Is this an accurate description ? Thanks, On Thu, Dec

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wal...@google.com wrote: We have many vma manipulation functions that are fast in the typical case, but can optionally be instructed to populate an unbounded number of ptes within the region they work on: - mmap with MAP_POPULATE or MAP_LOCKED

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski l...@amacapital.net wrote: On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wal...@google.com wrote: We have many vma manipulation functions that are fast in the typical case, but can optionally be instructed to populate an unbounded number of

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wal...@google.com wrote: On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski l...@amacapital.net wrote: On Thu, Dec 20, 2012 at 4:49 PM, Michel Lespinasse wal...@google.com wrote: We have many vma manipulation functions that are fast in the

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Michel Lespinasse
On Fri, Dec 21, 2012 at 5:09 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wal...@google.com wrote: On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski l...@amacapital.net wrote: Something's buggy here. My evil test case is stuck with lots of

Re: [PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-21 Thread Andy Lutomirski
On Fri, Dec 21, 2012 at 5:59 PM, Michel Lespinasse wal...@google.com wrote: On Fri, Dec 21, 2012 at 5:09 PM, Andy Lutomirski l...@amacapital.net wrote: On Fri, Dec 21, 2012 at 4:59 PM, Michel Lespinasse wal...@google.com wrote: On Fri, Dec 21, 2012 at 4:36 PM, Andy Lutomirski

[PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-20 Thread Michel Lespinasse
We have many vma manipulation functions that are fast in the typical case, but can optionally be instructed to populate an unbounded number of ptes within the region they work on: - mmap with MAP_POPULATE or MAP_LOCKED flags; - remap_file_pages() with MAP_NONBLOCK not set or when working on a

[PATCH 0/9] Avoid populating unbounded num of ptes with mmap_sem held

2012-12-20 Thread Michel Lespinasse
We have many vma manipulation functions that are fast in the typical case, but can optionally be instructed to populate an unbounded number of ptes within the region they work on: - mmap with MAP_POPULATE or MAP_LOCKED flags; - remap_file_pages() with MAP_NONBLOCK not set or when working on a