Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Yinghai Lu
On Fri, Dec 7, 2012 at 1:36 PM, Bjorn Helgaas wrote: > On Fri, Dec 7, 2012 at 2:30 PM, Yinghai Lu wrote: > > Sorry I missed that; I had only looked at a few patches adjacent to > the one that split out this code. > > I still would like the code to be all in pci_root.c. ok, I will rebase that to

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Fri, Dec 7, 2012 at 2:30 PM, Yinghai Lu wrote: > On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas wrote: >> On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: >>> From: Yinghai Lu >>> >>> >> For example, as soon as you put this code in pci_root.c instead of >> pci_root_hp.c, it becomes

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Yinghai Lu
On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas wrote: > On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: >> From: Yinghai Lu >> >> > For example, as soon as you put this code in pci_root.c instead of > pci_root_hp.c, it becomes obvious that we're keeping a list of host > bridges in both

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Rafael J. Wysocki
On Friday, December 07, 2012 12:32:46 PM Bjorn Helgaas wrote: > On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: > > From: Yinghai Lu > > > > It causes confusion. > > I completely agree that acpiphp causes confusion :) > > > We may only need acpi hp for pci host bridge. > > > > Split host

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe wrote: > From: Yinghai Lu > > It causes confusion. I completely agree that acpiphp causes confusion :) > We may only need acpi hp for pci host bridge. > > Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. > > -v2: put back

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe myron.st...@redhat.com wrote: From: Yinghai Lu ying...@kernel.org It causes confusion. I completely agree that acpiphp causes confusion :) We may only need acpi hp for pci host bridge. Split host bridge hot-add support to pci_root_hp, and keep

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Rafael J. Wysocki
On Friday, December 07, 2012 12:32:46 PM Bjorn Helgaas wrote: On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe myron.st...@redhat.com wrote: From: Yinghai Lu ying...@kernel.org It causes confusion. I completely agree that acpiphp causes confusion :) We may only need acpi hp for pci host

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Yinghai Lu
On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas bhelg...@google.com wrote: On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe myron.st...@redhat.com wrote: From: Yinghai Lu ying...@kernel.org For example, as soon as you put this code in pci_root.c instead of pci_root_hp.c, it becomes obvious that

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Bjorn Helgaas
On Fri, Dec 7, 2012 at 2:30 PM, Yinghai Lu ying...@kernel.org wrote: On Fri, Dec 7, 2012 at 11:32 AM, Bjorn Helgaas bhelg...@google.com wrote: On Thu, Dec 6, 2012 at 11:25 PM, Myron Stowe myron.st...@redhat.com wrote: From: Yinghai Lu ying...@kernel.org For example, as soon as you put this

Re: [PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-07 Thread Yinghai Lu
On Fri, Dec 7, 2012 at 1:36 PM, Bjorn Helgaas bhelg...@google.com wrote: On Fri, Dec 7, 2012 at 2:30 PM, Yinghai Lu ying...@kernel.org wrote: Sorry I missed that; I had only looked at a few patches adjacent to the one that split out this code. I still would like the code to be all in

[PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-06 Thread Myron Stowe
From: Yinghai Lu It causes confusion. We may only need acpi hp for pci host bridge. Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. -v2: put back pci_root_hp change in one patch -v3: add pcibios_resource_survey_bus() calling -v4: remove not needed code with

[PATCH 01/15] PCI, acpiphp: Separate out hot-add support of pci host bridge

2012-12-06 Thread Myron Stowe
From: Yinghai Lu ying...@kernel.org It causes confusion. We may only need acpi hp for pci host bridge. Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. -v2: put back pci_root_hp change in one patch -v3: add pcibios_resource_survey_bus() calling -v4: remove not needed