Re: [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-04 Thread Lance Roy
On Wed, Oct 03, 2018 at 11:00:51AM -0500, Bjorn Helgaas wrote: > On Tue, Oct 02, 2018 at 10:38:47PM -0700, Lance Roy wrote: > > lockdep_assert_held() is better suited to checking locking requirements, > > since it won't get confused when someone else holds the lock. This is > > also a step towards

Re: [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-04 Thread Lance Roy
On Wed, Oct 03, 2018 at 11:00:51AM -0500, Bjorn Helgaas wrote: > On Tue, Oct 02, 2018 at 10:38:47PM -0700, Lance Roy wrote: > > lockdep_assert_held() is better suited to checking locking requirements, > > since it won't get confused when someone else holds the lock. This is > > also a step towards

Re: [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-03 Thread Bjorn Helgaas
On Tue, Oct 02, 2018 at 10:38:47PM -0700, Lance Roy wrote: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy >

Re: [PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-03 Thread Bjorn Helgaas
On Tue, Oct 02, 2018 at 10:38:47PM -0700, Lance Roy wrote: > lockdep_assert_held() is better suited to checking locking requirements, > since it won't get confused when someone else holds the lock. This is > also a step towards possibly removing spin_is_locked(). > > Signed-off-by: Lance Roy >

[PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-02 Thread Lance Roy
lockdep_assert_held() is better suited to checking locking requirements, since it won't get confused when someone else holds the lock. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy Cc: Bjorn Helgaas Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav

[PATCH 01/16] x86/PCI: Replace spin_is_locked() with lockdep

2018-10-02 Thread Lance Roy
lockdep_assert_held() is better suited to checking locking requirements, since it won't get confused when someone else holds the lock. This is also a step towards possibly removing spin_is_locked(). Signed-off-by: Lance Roy Cc: Bjorn Helgaas Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav