Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-04 Thread Aneesh Kumar K.V
Hillf Danton writes: > On Fri, Aug 2, 2013 at 12:17 AM, Aneesh Kumar K.V > wrote: >> Hillf Danton writes: >> ... > >> >> Well, why is it illegal to use reserved page here? > >> > > >> > If we use reserved page here, other processes which are promised to > >> > use > >> >

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-04 Thread Aneesh Kumar K.V
Hillf Danton dhi...@gmail.com writes: On Fri, Aug 2, 2013 at 12:17 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Hillf Danton dhi...@gmail.com writes: ... Well, why is it illegal to use reserved page here? If we use reserved page here, other processes which are

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-03 Thread Hillf Danton
On Fri, Aug 2, 2013 at 12:17 AM, Aneesh Kumar K.V wrote: > Hillf Danton writes: > >> On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim wrote: >>> On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim wrote: > On Wed, Jul 31, 2013

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-03 Thread Hillf Danton
On Fri, Aug 2, 2013 at 12:17 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote: Hillf Danton dhi...@gmail.com writes: On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-01 Thread Aneesh Kumar K.V
Hillf Danton writes: > On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim wrote: >> On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: >>> On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim >>> wrote: >>> > On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: >>> >> On Wed, Jul 31,

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-01 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 11:25:04PM +0800, Hillf Danton wrote: > On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim wrote: > > On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: > >> On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim > >> wrote: > >> > On Wed, Jul 31, 2013 at 10:49:24AM +0800,

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-01 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 11:25:04PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-08-01 Thread Aneesh Kumar K.V
Hillf Danton dhi...@gmail.com writes: On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 10:49:24AM

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Hillf Danton
On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim wrote: > On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: >> On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim wrote: >> > On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: >> >> On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim >>

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: > On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim wrote: > > On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: > >> On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim > >> wrote: > >> > On Mon, Jul 29, 2013 at 03:24:46PM +0800,

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Hillf Danton
On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim wrote: > On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: >> On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim wrote: >> > On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: >> >> On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim >>

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Hillf Danton
On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: On Mon, Jul 29,

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Mon, Jul

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-31 Thread Hillf Danton
On Wed, Jul 31, 2013 at 2:37 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 02:21:38PM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 12:41 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: On Wed, Jul 31,

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: > On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim wrote: > > On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: > >> On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim > >> wrote: > >> > alloc_huge_page_node() use

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Hillf Danton
On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim wrote: > On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: >> On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim wrote: >> > alloc_huge_page_node() use dequeue_huge_page_node() without >> > any validation check, so it can steal reserved page

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Joonsoo Kim
On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: > On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim wrote: > > alloc_huge_page_node() use dequeue_huge_page_node() without > > any validation check, so it can steal reserved page unconditionally. > > Well, why is it illegal to use reserved

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > alloc_huge_page_node() use dequeue_huge_page_node() without > any validation check, so it can steal reserved page unconditionally. > To fix it, check the number of free_huge_page in > alloc_huge_page_node(). May be we should say. Don't use the reserve pool when soft

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: alloc_huge_page_node() use dequeue_huge_page_node() without any validation check, so it can steal reserved page unconditionally. To fix it, check the number of free_huge_page in alloc_huge_page_node(). May be we should say. Don't use the reserve

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Joonsoo Kim
On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: alloc_huge_page_node() use dequeue_huge_page_node() without any validation check, so it can steal reserved page unconditionally. Well, why is it illegal

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Hillf Danton
On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: alloc_huge_page_node() use dequeue_huge_page_node() without any validation

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-30 Thread Joonsoo Kim
On Wed, Jul 31, 2013 at 10:49:24AM +0800, Hillf Danton wrote: On Wed, Jul 31, 2013 at 10:27 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: On Mon, Jul 29, 2013 at 03:24:46PM +0800, Hillf Danton wrote: On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim iamjoonsoo@lge.com wrote:

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-29 Thread Hillf Danton
On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim wrote: > alloc_huge_page_node() use dequeue_huge_page_node() without > any validation check, so it can steal reserved page unconditionally. Well, why is it illegal to use reserved page here? > To fix it, check the number of free_huge_page in

Re: [PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-29 Thread Hillf Danton
On Mon, Jul 29, 2013 at 1:31 PM, Joonsoo Kim iamjoonsoo@lge.com wrote: alloc_huge_page_node() use dequeue_huge_page_node() without any validation check, so it can steal reserved page unconditionally. Well, why is it illegal to use reserved page here? To fix it, check the number of

[PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-28 Thread Joonsoo Kim
alloc_huge_page_node() use dequeue_huge_page_node() without any validation check, so it can steal reserved page unconditionally. To fix it, check the number of free_huge_page in alloc_huge_page_node(). Signed-off-by: Joonsoo Kim diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 6782b41..d971233

[PATCH 01/18] mm, hugetlb: protect reserved pages when softofflining requests the pages

2013-07-28 Thread Joonsoo Kim
alloc_huge_page_node() use dequeue_huge_page_node() without any validation check, so it can steal reserved page unconditionally. To fix it, check the number of free_huge_page in alloc_huge_page_node(). Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/hugetlb.c b/mm/hugetlb.c