Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

On Tue 2018-11-06 23:07:09, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of the struct

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

On Tue 2018-11-06 23:07:09, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of the struct

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Dan, Thanks for the review. On 11/08/2018 06:50 PM, Dan Murphy wrote: > Jacek > > On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: [...] >> >> /** >> - * of_led_classdev_register - register a new object of led_classdev class. >> + * led_classdev_register_ext - register a new object of

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Dan, Thanks for the review. On 11/08/2018 06:50 PM, Dan Murphy wrote: > Jacek > > On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: [...] >> >> /** >> - * of_led_classdev_register - register a new object of led_classdev class. >> + * led_classdev_register_ext - register a new object of

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Jacek On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of the

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Jacek On 11/06/2018 04:07 PM, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of the

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Baolin, Thanks for the review. Will address the remarks in a v2. On 11/07/2018 07:55 AM, Baolin Wang wrote: > Hi Jacek, > > On 7 November 2018 at 06:07, Jacek Anaszewski [...] > > It can work well for SC27XX LED, FWIW you can add my tested tag. > Tested-by: Baolin Wang > -- Best

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Baolin, Thanks for the review. Will address the remarks in a v2. On 11/07/2018 07:55 AM, Baolin Wang wrote: > Hi Jacek, > > On 7 November 2018 at 06:07, Jacek Anaszewski [...] > > It can work well for SC27XX LED, FWIW you can add my tested tag. > Tested-by: Baolin Wang > -- Best

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Jacek, On 7 November 2018 at 06:07, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of

Re: [PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Hi Jacek, On 7 November 2018 at 06:07, Jacek Anaszewski wrote: > Replace of_led_classdev_register() with led_classdev_register_ext(), which > accepts easily extendable struct led_init_data, instead of the fixed > struct device_node argument. The latter can be now passed in a fwnode > property of

[PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Replace of_led_classdev_register() with led_classdev_register_ext(), which accepts easily extendable struct led_init_data, instead of the fixed struct device_node argument. The latter can be now passed in a fwnode property of the struct led_init_data. The modification is driven by the need for

[PATCH 01/24] leds: class: Improve LED and LED flash class registration API

Replace of_led_classdev_register() with led_classdev_register_ext(), which accepts easily extendable struct led_init_data, instead of the fixed struct device_node argument. The latter can be now passed in a fwnode property of the struct led_init_data. The modification is driven by the need for