Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-06-11 Thread Sekhar Nori
On 5/22/2013 12:40 PM, Philip Avinash wrote: > 1. Corrects coding and commenting styles > 2. Variables name change to meaningful name > 3. Remove unnecessary variable usage > 4. Add BINTEN macro definition > > Signed-off-by: Philip Avinash As Russell mentioned, the 80 char limit changes are

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-06-11 Thread Sekhar Nori
On 5/22/2013 12:40 PM, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash avinashphi...@ti.com As Russell mentioned, the 80 char limit

RE: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-23 Thread Philip, Avinash
On Wed, May 22, 2013 at 20:10:42, Russell King - ARM Linux wrote: > On Wed, May 22, 2013 at 12:40:25PM +0530, Philip Avinash wrote: > > /* > > * Assuming the pin is muxed as a gpio output, set its output value. > > */ > > -static void > > -davinci_gpio_set(struct gpio_chip *chip, unsigned

RE: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-23 Thread Philip, Avinash
On Wed, May 22, 2013 at 18:29:46, Sergei Shtylyov wrote: > Hello. > > On 22-05-2013 11:10, Philip Avinash wrote: > > > 1. Corrects coding and commenting styles > > 2. Variables name change to meaningful name > > 3. Remove unnecessary variable usage > > 4. Add BINTEN macro definition > > > >

RE: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-23 Thread Philip, Avinash
On Wed, May 22, 2013 at 20:10:42, Russell King - ARM Linux wrote: On Wed, May 22, 2013 at 12:40:25PM +0530, Philip Avinash wrote: /* * Assuming the pin is muxed as a gpio output, set its output value. */ -static void -davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int

RE: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-23 Thread Philip, Avinash
On Wed, May 22, 2013 at 18:29:46, Sergei Shtylyov wrote: Hello. On 22-05-2013 11:10, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by:

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Russell King - ARM Linux
On Wed, May 22, 2013 at 12:40:25PM +0530, Philip Avinash wrote: > /* > * Assuming the pin is muxed as a gpio output, set its output value. > */ > -static void > -davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value) > +static void davinci_gpio_set(struct gpio_chip *chip,

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 11:10, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash --- drivers/gpio/gpio-davinci.c | 182

[PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Philip Avinash
1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash --- drivers/gpio/gpio-davinci.c | 182 +-- 1 file changed, 89

[PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Philip Avinash
1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash avinashphi...@ti.com --- drivers/gpio/gpio-davinci.c | 182 +-- 1 file

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Sergei Shtylyov
Hello. On 22-05-2013 11:10, Philip Avinash wrote: 1. Corrects coding and commenting styles 2. Variables name change to meaningful name 3. Remove unnecessary variable usage 4. Add BINTEN macro definition Signed-off-by: Philip Avinash avinashphi...@ti.com --- drivers/gpio/gpio-davinci.c |

Re: [PATCH 02/11] gpio: davinci: coding style correction

2013-05-22 Thread Russell King - ARM Linux
On Wed, May 22, 2013 at 12:40:25PM +0530, Philip Avinash wrote: /* * Assuming the pin is muxed as a gpio output, set its output value. */ -static void -davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static void davinci_gpio_set(struct gpio_chip *chip, unsigned