Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-02 Thread Christoph Hellwig
On Fri, Aug 02, 2013 at 11:11:33AM +1000, Dave Chinner wrote: > But that doesn't fix the problem of taking the hash lock in evict() > when it is not necessary. If everything sets I_NEEDS_WRITEBACK, and > we still fake hashing the inode, how are do we know that we don't > need to unhash it in

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-02 Thread Christoph Hellwig
On Fri, Aug 02, 2013 at 11:11:33AM +1000, Dave Chinner wrote: But that doesn't fix the problem of taking the hash lock in evict() when it is not necessary. If everything sets I_NEEDS_WRITEBACK, and we still fake hashing the inode, how are do we know that we don't need to unhash it in evict()?

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-01 Thread Dave Chinner
On Thu, Aug 01, 2013 at 01:12:35AM -0700, Christoph Hellwig wrote: > On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > Some filesystems don't use the VFS inode hash and fake the fact they > > are hashed so that all the writeback code works correctly.

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-01 Thread Christoph Hellwig
On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote: > From: Dave Chinner > > Some filesystems don't use the VFS inode hash and fake the fact they > are hashed so that all the writeback code works correctly. However, > this means the evict() path still tries to remove the inode from the

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-01 Thread Christoph Hellwig
On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com Some filesystems don't use the VFS inode hash and fake the fact they are hashed so that all the writeback code works correctly. However, this means the evict() path still tries to remove the

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-08-01 Thread Dave Chinner
On Thu, Aug 01, 2013 at 01:12:35AM -0700, Christoph Hellwig wrote: On Wed, Jul 31, 2013 at 02:15:41PM +1000, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com Some filesystems don't use the VFS inode hash and fake the fact they are hashed so that all the writeback code works

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-07-31 Thread Jan Kara
On Wed 31-07-13 14:15:41, Dave Chinner wrote: > From: Dave Chinner > > Some filesystems don't use the VFS inode hash and fake the fact they > are hashed so that all the writeback code works correctly. However, > this means the evict() path still tries to remove the inode from the > hash, meaning

Re: [PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-07-31 Thread Jan Kara
On Wed 31-07-13 14:15:41, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com Some filesystems don't use the VFS inode hash and fake the fact they are hashed so that all the writeback code works correctly. However, this means the evict() path still tries to remove the inode from the

[PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-07-30 Thread Dave Chinner
From: Dave Chinner Some filesystems don't use the VFS inode hash and fake the fact they are hashed so that all the writeback code works correctly. However, this means the evict() path still tries to remove the inode from the hash, meaning that the inode_hash_lock() needs to be taken

[PATCH 02/11] inode: add IOP_NOTHASHED to avoid inode hash lock in evict

2013-07-30 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com Some filesystems don't use the VFS inode hash and fake the fact they are hashed so that all the writeback code works correctly. However, this means the evict() path still tries to remove the inode from the hash, meaning that the inode_hash_lock() needs to be