Re: [PATCH 02/19] elf: Move arch_setup_additional_pages() to generic elf.h

2020-11-12 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Yet something to improve: [auto build test ERROR on c34f157421f6905e6b4a79a312e9175dce2bc607] url: https://github.com/0day-ci/linux/commits/Dmitry-Safonov/Add-generic-user_landing-tracking/20201109-090354 base:c34f157421f6905e6b4a79a312e9175dce2bc607

Re: [PATCH 02/19] elf: Move arch_setup_additional_pages() to generic elf.h

2020-11-12 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on c34f157421f6905e6b4a79a312e9175dce2bc607] url: https://github.com/0day-ci/linux/commits/Dmitry-Safonov/Add-generic-user_landing-tracking/20201109-090354 base:

[PATCH 02/19] elf: Move arch_setup_additional_pages() to generic elf.h

2020-11-07 Thread Dmitry Safonov
Ifdef the function in the header, not in the code. Following kernel style, move it to Kconfig. All it makes it easier to follow when the option is enabled/disabled. Remove re-definition from compat_binfmt_elf, as it's always defined under compat_arch_setup_additional_pages (to be reworked).