Re: [PATCH 02/20] crypto: Manual replacement of the deprecated strlcpy() with return values

2021-03-03 Thread Herbert Xu
On Mon, Feb 22, 2021 at 04:12:13PM +0100, Romain Perier wrote: > > diff --git a/crypto/lrw.c b/crypto/lrw.c > index bcf09fbc750a..4d35f4439012 100644 > --- a/crypto/lrw.c > +++ b/crypto/lrw.c > @@ -357,10 +357,10 @@ static int lrw_create(struct crypto_template *tmpl, > struct rtattr **tb) >

[PATCH 02/20] crypto: Manual replacement of the deprecated strlcpy() with return values

2021-02-22 Thread Romain Perier
The strlcpy() reads the entire source buffer first, it is dangerous if the source buffer lenght is unbounded or possibility non NULL-terminated. It can lead to linear read overflows, crashes, etc... As recommended in the deprecated interfaces [1], it should be replaced by strscpy. This commit