Re: [PATCH 03/14] pwm: meson: use GENMASK and FIELD_PREP for the lo and hi values

2019-05-27 Thread Neil Armstrong
On 25/05/2019 20:11, Martin Blumenstingl wrote: > meson_pwm_calc() ensures that "lo" is always less than 16 bits wide > (otherwise it would overflow into the "hi" part of the REG_PWM_{A,B} > register). > Use GENMASK and FIELD_PREP for the lo and hi values to make it easier to > spot how wide these

[PATCH 03/14] pwm: meson: use GENMASK and FIELD_PREP for the lo and hi values

2019-05-25 Thread Martin Blumenstingl
meson_pwm_calc() ensures that "lo" is always less than 16 bits wide (otherwise it would overflow into the "hi" part of the REG_PWM_{A,B} register). Use GENMASK and FIELD_PREP for the lo and hi values to make it easier to spot how wide these are internally. Additionally this is a preparation step