Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-07 Thread NeilBrown
On Wed, Apr 03 2019, George Hilliard wrote: > On Tue, Apr 2, 2019 at 3:45 PM Christian Lütke-Stetzkamp > wrote: >> There are two other larger differences that I found during my >> work. One is that drivers/mmc/host/mtk-sd.c has much more features, >> like voltage and clock handling and some

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-03 Thread George Hilliard
On Tue, Apr 2, 2019 at 3:45 PM Christian Lütke-Stetzkamp wrote: > There are two other larger differences that I found during my > work. One is that drivers/mmc/host/mtk-sd.c has much more features, > like voltage and clock handling and some support for high speed > modes. I don't know if these

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-02 Thread NeilBrown
On Tue, Apr 02 2019, Christian Lütke-Stetzkamp wrote: > On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote: >> People keep telling me that drivers/mmc/host/mtk-sd.c should be able to >> handle the same hardware as this driver, with a little bit of work. >> Unfortunately they haven't told

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-02 Thread Christian Lütke-Stetzkamp
On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote: > People keep telling me that drivers/mmc/host/mtk-sd.c should be able to > handle the same hardware as this driver, with a little bit of work. > Unfortunately they haven't told me what the little bit of work involves. > > Have you

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-02 Thread NeilBrown
On Tue, Apr 02 2019, George Hilliard wrote: > On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman > wrote: > >> The license text in this driver is "interesting" and not really obvious >> that it is supposed to be able to be distributed in the kernel source >> tree. Yes, the MODULE_LICENSE() text

Re: [PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-02 Thread Greg Kroah-Hartman
On Tue, Apr 02, 2019 at 06:16:47AM -0500, George Hilliard wrote: > On Tue, Apr 2, 2019, 5:32 AM Greg Kroah-Hartman > wrote: > > > The license text in this driver is "interesting" and not really obvious > > that it is supposed to be able to be distributed in the kernel source > > tree. Yes, the

[PATCH 03/16] staging: m57621-mmc: delete driver from the tree.

2019-04-02 Thread Greg Kroah-Hartman
The license text in this driver is "interesting" and not really obvious that it is supposed to be able to be distributed in the kernel source tree. Yes, the MODULE_LICENSE() text says GPL, so it's probably ok, but to be safe, I am deleting this driver. I will be glad to add it back if the