On Wednesday 24 April 2013, Lee Jones wrote:
> Yeah, I agree, although does it make a difference?
>
> Is it evaluated a second time, or does it take up extra cycles by being
> enclosed in parentheses?
>
> Or is this just a coding style thing?
Just coding style. I agree you should have no
On Wed, Apr 24, 2013 at 06:00:28PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 24-04-2013 10:53, Lee Jones wrote:
>
> >>> struct musb_hdrc_platform_data *plat = dev->platform_data;
> >>>- struct ux500_musb_board_data *data = plat->board_data;
> >>>+ struct ux500_musb_board_data *data;
>
>
Hello.
On 24-04-2013 10:53, Lee Jones wrote:
struct musb_hdrc_platform_data *plat = dev->platform_data;
- struct ux500_musb_board_data *data = plat->board_data;
+ struct ux500_musb_board_data *data;
- param_array = data->dma_rx_param_array;
+ param_array =
Hi Sergei,
> > struct musb_hdrc_platform_data *plat = dev->platform_data;
> >-struct ux500_musb_board_data *data = plat->board_data;
> >+struct ux500_musb_board_data *data;
> >-param_array = data->dma_rx_param_array;
> >+param_array = (data) ? data->dma_rx_param_array : NULL;
Hi Sergei,
struct musb_hdrc_platform_data *plat = dev-platform_data;
-struct ux500_musb_board_data *data = plat-board_data;
+struct ux500_musb_board_data *data;
-param_array = data-dma_rx_param_array;
+param_array = (data) ? data-dma_rx_param_array : NULL;
Why
Hello.
On 24-04-2013 10:53, Lee Jones wrote:
struct musb_hdrc_platform_data *plat = dev-platform_data;
- struct ux500_musb_board_data *data = plat-board_data;
+ struct ux500_musb_board_data *data;
- param_array = data-dma_rx_param_array;
+ param_array =
On Wed, Apr 24, 2013 at 06:00:28PM +0400, Sergei Shtylyov wrote:
Hello.
On 24-04-2013 10:53, Lee Jones wrote:
struct musb_hdrc_platform_data *plat = dev-platform_data;
- struct ux500_musb_board_data *data = plat-board_data;
+ struct ux500_musb_board_data *data;
- param_array =
On Wednesday 24 April 2013, Lee Jones wrote:
Yeah, I agree, although does it make a difference?
Is it evaluated a second time, or does it take up extra cycles by being
enclosed in parentheses?
Or is this just a coding style thing?
Just coding style. I agree you should have no parentheses
Hello.
On 04/23/2013 07:03 PM, Lee Jones wrote:
In its current state, the ux500-musb driver uses platform data pointers
blindly with no prior checking. If no platform data pointer is passed
this will Oops the kernel. In this patch we ensure platform data and
board data are present prior to
In its current state, the ux500-musb driver uses platform data pointers
blindly with no prior checking. If no platform data pointer is passed
this will Oops the kernel. In this patch we ensure platform data and
board data are present prior to using them.
Cc: Felipe Balbi
Cc:
In its current state, the ux500-musb driver uses platform data pointers
blindly with no prior checking. If no platform data pointer is passed
this will Oops the kernel. In this patch we ensure platform data and
board data are present prior to using them.
Cc: Felipe Balbi ba...@ti.com
Cc:
Hello.
On 04/23/2013 07:03 PM, Lee Jones wrote:
In its current state, the ux500-musb driver uses platform data pointers
blindly with no prior checking. If no platform data pointer is passed
this will Oops the kernel. In this patch we ensure platform data and
board data are present prior to
12 matches
Mail list logo
