Re: [PATCH 04/22] gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 06:02 Kent Gibson napisaƂ(a): > > Refactor the mapping from handle flags to desc flags into a helper > function. > > The assign_bit is overkill where it is replacing the set_bit cases, as is > rechecking bits known to be clear in some circumstances, but the DRY > simplification

[PATCH 04/22] gpiolib: cdev: refactor gpiohandle_flags_to_desc_flags

2020-06-22 Thread Kent Gibson
Refactor the mapping from handle flags to desc flags into a helper function. The assign_bit is overkill where it is replacing the set_bit cases, as is rechecking bits known to be clear in some circumstances, but the DRY simplification more than makes up for any performance degradation, especially