Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-14 Thread Harvey Harrison
On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote: > On Wed, 13 Feb 2008 21:14:18 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Avoid a metric ton of sparse warnings like: > > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one > > drivers/ata/pata_ali.c:176:14:

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-14 Thread Alan Cox
On Wed, 13 Feb 2008 21:14:18 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Avoid a metric ton of sparse warnings like: > drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one > drivers/ata/pata_ali.c:176:14: originally declared here NAK that appears to be a sparse bug.

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-14 Thread Alan Cox
On Wed, 13 Feb 2008 21:14:18 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here NAK that appears to be a sparse bug.

Re: [PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-14 Thread Harvey Harrison
On Thu, 2008-02-14 at 12:01 +, Alan Cox wrote: On Wed, 13 Feb 2008 21:14:18 -0800 Harvey Harrison [EMAIL PROTECTED] wrote: Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally

[PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-13 Thread Harvey Harrison
Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison

[PATCH 05/11] ata: replace macro with static inline in libata.h

2008-02-13 Thread Harvey Harrison
Avoid a metric ton of sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison