Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-08 Thread Maxime Ripard
On Tue, Jul 08, 2014 at 10:08:14AM +0200, Maxime Ripard wrote: > On Mon, Jul 07, 2014 at 08:40:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > > > > >> move this to an assembly file more easy to read than a C code > > > > > > > > > > > > Nope. It's a pain to pass variable to an

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-08 Thread Maxime Ripard
On Mon, Jul 07, 2014 at 08:40:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > >> move this to an assembly file more easy to read than a C code > > > > > > > > > > Nope. It's a pain to pass variable to an external assembly file, and > > > > > this makes the use of global variable

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-08 Thread Maxime Ripard
On Mon, Jul 07, 2014 at 08:40:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: move this to an assembly file more easy to read than a C code Nope. It's a pain to pass variable to an external assembly file, and this makes the use of global variable pretty much mandatory,

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-08 Thread Maxime Ripard
On Tue, Jul 08, 2014 at 10:08:14AM +0200, Maxime Ripard wrote: On Mon, Jul 07, 2014 at 08:40:01PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote: move this to an assembly file more easy to read than a C code Nope. It's a pain to pass variable to an external assembly file, and

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:06 Fri 04 Jul , Maxime Ripard wrote: > On Fri, Jul 04, 2014 at 09:14:43AM +0200, Boris BREZILLON wrote: > > On Fri, 4 Jul 2014 11:08:20 +0800 > > Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > > > > On Jul 3, 2014, at 10:59 PM, Maxime Ripard > > > wrote: > > > > > > > On Thu,

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-07 Thread Jean-Christophe PLAGNIOL-VILLARD
On 11:06 Fri 04 Jul , Maxime Ripard wrote: On Fri, Jul 04, 2014 at 09:14:43AM +0200, Boris BREZILLON wrote: On Fri, 4 Jul 2014 11:08:20 +0800 Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On Jul 3, 2014, at 10:59 PM, Maxime Ripard

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Maxime Ripard
On Fri, Jul 04, 2014 at 09:14:43AM +0200, Boris BREZILLON wrote: > On Fri, 4 Jul 2014 11:08:20 +0800 > Jean-Christophe PLAGNIOL-VILLARD wrote: > > > > > On Jul 3, 2014, at 10:59 PM, Maxime Ripard > > wrote: > > > > > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe > > >

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Maxime Ripard
On Fri, Jul 04, 2014 at 10:40:56AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On Jul 3, 2014, at 10:59 PM, Maxime Ripard > wrote: > > > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > >>> +++ b/drivers/power/reset/at91-reset.c > >>> @@ -0,0

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Boris BREZILLON
On Fri, 4 Jul 2014 11:08:20 +0800 Jean-Christophe PLAGNIOL-VILLARD wrote: > > On Jul 3, 2014, at 10:59 PM, Maxime Ripard > wrote: > > > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > > wrote: > >>> +++ b/drivers/power/reset/at91-reset.c > >>> @@ -0,0 +1,202 @@

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard wrote: > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: >>> +++ b/drivers/power/reset/at91-reset.c >>> @@ -0,0 +1,202 @@ >>> +/* >>> + * Atmel AT91 SAM9 SoCs reset code >>> + * >>> + * Copyright (C) 2014 Maxime

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: +++ b/drivers/power/reset/at91-reset.c @@ -0,0 +1,202 @@ +/* + * Atmel AT91 SAM9 SoCs reset code + * + * Copyright (C)

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Boris BREZILLON
On Fri, 4 Jul 2014 11:08:20 +0800 Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On Jul 3, 2014, at 10:59 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: +++

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Maxime Ripard
On Fri, Jul 04, 2014 at 10:40:56AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: On Jul 3, 2014, at 10:59 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: +++

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-04 Thread Maxime Ripard
On Fri, Jul 04, 2014 at 09:14:43AM +0200, Boris BREZILLON wrote: On Fri, 4 Jul 2014 11:08:20 +0800 Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com wrote: On Jul 3, 2014, at 10:59 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Jul 03, 2014 at 10:39:08PM

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard wrote: > On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: >>> +++ b/drivers/power/reset/at91-reset.c >>> @@ -0,0 +1,202 @@ >>> +/* >>> + * Atmel AT91 SAM9 SoCs reset code >>> + * >>> + * Copyright (C) 2014 Maxime

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Maxime Ripard
On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > > +++ b/drivers/power/reset/at91-reset.c > > @@ -0,0 +1,202 @@ > > +/* > > + * Atmel AT91 SAM9 SoCs reset code > > + * > > + * Copyright (C) 2014 Maxime Ripard > > + * > > + * Maxime Ripard > > you can not own

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
NACK On Jul 3, 2014, at 10:14 PM, Maxime Ripard wrote: > > Implement the reset behaviour of the various AT91 SoCS in drivers/power/reset. > > It used to be (and still is) located in arch/arm/mach-at91, and in order to > preserve bisectability is not removed yet, but every board should be

[PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Maxime Ripard
Implement the reset behaviour of the various AT91 SoCS in drivers/power/reset. It used to be (and still is) located in arch/arm/mach-at91, and in order to preserve bisectability is not removed yet, but every board should be converted to use this driver instead. Signed-off-by: Maxime Ripard ---

[PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Maxime Ripard
Implement the reset behaviour of the various AT91 SoCS in drivers/power/reset. It used to be (and still is) located in arch/arm/mach-at91, and in order to preserve bisectability is not removed yet, but every board should be converted to use this driver instead. Signed-off-by: Maxime Ripard

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
NACK On Jul 3, 2014, at 10:14 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: Implement the reset behaviour of the various AT91 SoCS in drivers/power/reset. It used to be (and still is) located in arch/arm/mach-at91, and in order to preserve bisectability is not removed yet,

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Maxime Ripard
On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: +++ b/drivers/power/reset/at91-reset.c @@ -0,0 +1,202 @@ +/* + * Atmel AT91 SAM9 SoCs reset code + * + * Copyright (C) 2014 Maxime Ripard + * + * Maxime Ripard maxime.rip...@free-electrons.com you

Re: [PATCH 05/18] power: reset: Add AT91 reset driver

2014-07-03 Thread Jean-Christophe PLAGNIOL-VILLARD
On Jul 3, 2014, at 10:59 PM, Maxime Ripard maxime.rip...@free-electrons.com wrote: On Thu, Jul 03, 2014 at 10:39:08PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: +++ b/drivers/power/reset/at91-reset.c @@ -0,0 +1,202 @@ +/* + * Atmel AT91 SAM9 SoCs reset code + * + * Copyright (C)