Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, 25 Apr 2013, Linus Walleij wrote: > On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > down the driver. This simple macro should make many of them a little > > simpler to decipher. The remainder have to stay

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones wrote: > There are lots of lengthy if() statements located sporadically up and > down the driver. This simple macro should make many of them a little > simpler to decipher. The remainder have to stay in place, as they > detail slightly more specific

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder have to stay in place, as they detail slightly

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, 25 Apr 2013, Linus Walleij wrote: On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones lee.jo...@linaro.org wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, 22 Apr 2013, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > > down the driver. This simple macro should make many of them a little >

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, 22 Apr 2013, Lee Jones wrote: On Mon, 22 Apr 2013, Vinod Koul wrote: On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, Apr 22, 2013 at 11:27:48AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > > down the driver. This simple macro should make

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, 22 Apr 2013, Vinod Koul wrote: > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > There are lots of lengthy if() statements located sporadically up and > > down the driver. This simple macro should make many of them a little > > simpler to decipher. The remainder have to

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > There are lots of lengthy if() statements located sporadically up and > down the driver. This simple macro should make many of them a little > simpler to decipher. The remainder have to stay in place, as they > detail slightly more

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder have to stay in place, as they detail slightly more specific

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, 22 Apr 2013, Vinod Koul wrote: On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder have to stay in

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Mon, Apr 22, 2013 at 11:27:48AM +0100, Lee Jones wrote: On Mon, 22 Apr 2013, Vinod Koul wrote: On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thursday 18 April 2013, Lee Jones wrote: > +#define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) > +#define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ > + (dir == STEDMA40_MEM_TO_MEM)) ? true : false) > + The redundant "? true : false"

[PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder have to stay in place, as they detail slightly more specific settings. Cc: Vinod Koul Cc: Dan Williams Cc: Per Forlin

[PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

There are lots of lengthy if() statements located sporadically up and down the driver. This simple macro should make many of them a little simpler to decipher. The remainder have to stay in place, as they detail slightly more specific settings. Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams

Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions

On Thursday 18 April 2013, Lee Jones wrote: +#define D40_IS_SRC(dir) ((dir == STEDMA40_PERIPH_TO_MEM) ? true : false) +#define D40_IS_DST(dir) (((dir == STEDMA40_MEM_TO_PERIPH) || \ + (dir == STEDMA40_MEM_TO_MEM)) ? true : false) + The redundant ? true : false part is