Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-06 Thread Jingoo Han
On Wednesday, March 06, 2013 5:26 PM, Thomas Petazzoni wrote: > > Dear Jingoo Han, > > On Wed, 06 Mar 2013 06:28:08 + (GMT), Jingoo Han wrote: > > > Sorry, I did not know that you submitted the patch. > > No problem, I'm happy to have one less patch to carry in my PCIe patch > set :)

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-06 Thread Thomas Petazzoni
Dear Jingoo Han, On Wed, 06 Mar 2013 06:28:08 + (GMT), Jingoo Han wrote: > Sorry, I did not know that you submitted the patch. No problem, I'm happy to have one less patch to carry in my PCIe patch set :) > Like you, I am developing PCIe Host driver. Just curious, do you already have some

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-06 Thread Thomas Petazzoni
Dear Jingoo Han, On Wed, 06 Mar 2013 06:28:08 + (GMT), Jingoo Han wrote: Sorry, I did not know that you submitted the patch. No problem, I'm happy to have one less patch to carry in my PCIe patch set :) Like you, I am developing PCIe Host driver. Just curious, do you already have some

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-06 Thread Jingoo Han
On Wednesday, March 06, 2013 5:26 PM, Thomas Petazzoni wrote: Dear Jingoo Han, On Wed, 06 Mar 2013 06:28:08 + (GMT), Jingoo Han wrote: Sorry, I did not know that you submitted the patch. No problem, I'm happy to have one less patch to carry in my PCIe patch set :) Thank you :)

Re: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-05 Thread Jingoo Han
On Tuesday, March 05, 2013 5:30 AM, Arnd Bergmann wrote: > > On Monday 04 March 2013, Thomas Petazzoni wrote: > > FWIW, a patch that is doing what I was initially proposing has been > > merged for 3.9, and it doesn't contain the > > IS_ENABLED(CONFIG_HAS_IOPORT) test you were proposing (and which

Re: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-05 Thread Jingoo Han
On Tuesday, March 05, 2013 5:30 AM, Arnd Bergmann wrote: On Monday 04 March 2013, Thomas Petazzoni wrote: FWIW, a patch that is doing what I was initially proposing has been merged for 3.9, and it doesn't contain the IS_ENABLED(CONFIG_HAS_IOPORT) test you were proposing (and which I

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-04 Thread Arnd Bergmann
On Monday 04 March 2013, Thomas Petazzoni wrote: > FWIW, a patch that is doing what I was initially proposing has been > merged for 3.9, and it doesn't contain the > IS_ENABLED(CONFIG_HAS_IOPORT) test you were proposing (and which I > think was correct). See: > > commit

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-04 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 Feb 2013 22:36:37 +, Arnd Bergmann wrote: > > I have the feeling that the problem is more complex than that. My > > understanding is that the pcim_iomap_regions() function used by > > drivers/ata/libata-sff.c can perfectly be used to map memory BARs, and > >

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-04 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 Feb 2013 22:36:37 +, Arnd Bergmann wrote: I have the feeling that the problem is more complex than that. My understanding is that the pcim_iomap_regions() function used by drivers/ata/libata-sff.c can perfectly be used to map memory BARs, and not

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-03-04 Thread Arnd Bergmann
On Monday 04 March 2013, Thomas Petazzoni wrote: FWIW, a patch that is doing what I was initially proposing has been merged for 3.9, and it doesn't contain the IS_ENABLED(CONFIG_HAS_IOPORT) test you were proposing (and which I think was correct). See: commit

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: > > Any driver that requires a > > linear mapping of I/O ports to __iomem pointers must depend > > CONFIG_HAS_IOPORT with the current definition of that symbol (as > > mentioned before, we should really rename that to > > CONFIG_HAS_IOPORT_MAP).

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 Feb 2013 18:00:48 +, Arnd Bergmann wrote: > On Tuesday 12 February 2013, Thomas Petazzoni wrote: > > The pcim_*() functions are used by the libata-sff subsystem, and > > this subsystem is used for many SATA drivers on ARM platforms that > > do not necessarily

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: > The pcim_*() functions are used by the libata-sff subsystem, and this > subsystem is used for many SATA drivers on ARM platforms that do not > necessarily have I/O ports. > > Signed-off-by: Thomas Petazzoni > Cc: Paul Gortmaker > Cc: Jesse

[PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni Cc: Paul Gortmaker Cc: Jesse Barnes Cc: Yinghai Lu Cc: linux-kernel@vger.kernel.org ---

[PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc: Paul Gortmaker paul.gortma...@windriver.com Cc: Jesse

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O ports. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Cc:

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Thomas Petazzoni
Dear Arnd Bergmann, On Tue, 12 Feb 2013 18:00:48 +, Arnd Bergmann wrote: On Tuesday 12 February 2013, Thomas Petazzoni wrote: The pcim_*() functions are used by the libata-sff subsystem, and this subsystem is used for many SATA drivers on ARM platforms that do not necessarily have I/O

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

2013-02-12 Thread Arnd Bergmann
On Tuesday 12 February 2013, Thomas Petazzoni wrote: Any driver that requires a linear mapping of I/O ports to __iomem pointers must depend CONFIG_HAS_IOPORT with the current definition of that symbol (as mentioned before, we should really rename that to CONFIG_HAS_IOPORT_MAP). Having