Re: [PATCH 06/11] bdi: add a new writeback list for sync

2013-08-01 Thread Dave Chinner
On Wed, Jul 31, 2013 at 05:11:14PM +0200, Jan Kara wrote: > On Wed 31-07-13 14:15:45, Dave Chinner wrote: > > /* > > + * mark an inode as under writeback on the given bdi > > + */ > > +void bdi_mark_inode_writeback(struct backing_dev_info *bdi, struct inode > > *inode) > > +{ > > +

Re: [PATCH 06/11] bdi: add a new writeback list for sync

2013-08-01 Thread Dave Chinner
On Wed, Jul 31, 2013 at 05:11:14PM +0200, Jan Kara wrote: On Wed 31-07-13 14:15:45, Dave Chinner wrote: /* + * mark an inode as under writeback on the given bdi + */ +void bdi_mark_inode_writeback(struct backing_dev_info *bdi, struct inode *inode) +{ + WARN_ON_ONCE(bdi !=

Re: [PATCH 06/11] bdi: add a new writeback list for sync

2013-07-31 Thread Jan Kara
On Wed 31-07-13 14:15:45, Dave Chinner wrote: > From: Dave Chinner > > wait_sb_inodes() current does a walk of all inodes in the filesystem > to find dirty one to wait on during sync. This is highly > inefficient and wastes a lot of CPU when there are lots of clean > cached inodes that we don't

Re: [PATCH 06/11] bdi: add a new writeback list for sync

2013-07-31 Thread Jan Kara
On Wed 31-07-13 14:15:45, Dave Chinner wrote: From: Dave Chinner dchin...@redhat.com wait_sb_inodes() current does a walk of all inodes in the filesystem to find dirty one to wait on during sync. This is highly inefficient and wastes a lot of CPU when there are lots of clean cached inodes

[PATCH 06/11] bdi: add a new writeback list for sync

2013-07-30 Thread Dave Chinner
From: Dave Chinner wait_sb_inodes() current does a walk of all inodes in the filesystem to find dirty one to wait on during sync. This is highly inefficient and wastes a lot of CPU when there are lots of clean cached inodes that we don't need to wait on. To avoid this "all inode" walk, we need

[PATCH 06/11] bdi: add a new writeback list for sync

2013-07-30 Thread Dave Chinner
From: Dave Chinner dchin...@redhat.com wait_sb_inodes() current does a walk of all inodes in the filesystem to find dirty one to wait on during sync. This is highly inefficient and wastes a lot of CPU when there are lots of clean cached inodes that we don't need to wait on. To avoid this all