Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 29/06/17 03:35 PM, Allen Hubbe wrote: >> It is not a workaround for alignment restrictions of the mws. It is a >> restriction to avoid the use of >> doorbells and scratchpads. Memory windows are used exclusively. >> >> Read msi-x local and send that to the peer: > >

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 29/06/17 03:35 PM, Allen Hubbe wrote: >> It is not a workaround for alignment restrictions of the mws. It is a >> restriction to avoid the use of >> doorbells and scratchpads. Memory windows are used exclusively. >> >> Read msi-x local and send that to the peer: > >

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

Let me try that again... From: Hubbe, Allen > From: Logan Gunthorpe > > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > > Unfortunately, it is to work around hardware errata. That is not so > > > trivial to fix. > > > > Can you describe more what the work around is doing? Can you share the > >

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

Let me try that again... From: Hubbe, Allen > From: Logan Gunthorpe > > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > > Unfortunately, it is to work around hardware errata. That is not so > > > trivial to fix. > > > > Can you describe more what the work around is doing? Can you share the > >

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > Unfortunately, it is to work around hardware errata. That is not so > > trivial to fix. > > Can you describe more what the work around is doing? Can you share the > code? It seems odd that a workaround is based on the

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > Unfortunately, it is to work around hardware errata. That is not so > > trivial to fix. > > Can you describe more what the work around is doing? Can you share the > code? It seems odd that a workaround is based on the

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 6/29/2017 2:13 PM, Allen Hubbe wrote: Unfortunately, it is to work around hardware errata. That is not so trivial to fix. Can you describe more what the work around is doing? Can you share the code? It seems odd that a workaround is based on the alignment restrictions of the mws.

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 6/29/2017 2:13 PM, Allen Hubbe wrote: Unfortunately, it is to work around hardware errata. That is not so trivial to fix. Can you describe more what the work around is doing? Can you share the code? It seems odd that a workaround is based on the alignment restrictions of the mws.

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 12:11 PM, Allen Hubbe wrote: > > Nak. This breaks a work around for stability issues on some hardware. I > > am ok with changing the > comment to say, this is only supported when called after link up. I would > still like to allow these > to be called at

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 12:11 PM, Allen Hubbe wrote: > > Nak. This breaks a work around for stability issues on some hardware. I > > am ok with changing the > comment to say, this is only supported when called after link up. I would > still like to allow these > to be called at

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 6/29/2017 12:11 PM, Allen Hubbe wrote: Nak. This breaks a work around for stability issues on some hardware. I am ok with changing the comment to say, this is only supported when called after link up. I would still like to allow these to be called at any time. Specific hardware drivers

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

On 6/29/2017 12:11 PM, Allen Hubbe wrote: Nak. This breaks a work around for stability issues on some hardware. I am ok with changing the comment to say, this is only supported when called after link up. I would still like to allow these to be called at any time. Specific hardware drivers

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > This patch adds a comment and a check to the ntb_mw_get_align and > ntb_mw_count functions so that they always fail if the function is > called before the link is up. > > This is to prevent accidental mis-use in clients that are testing > on hardware that this doesn't

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > This patch adds a comment and a check to the ntb_mw_get_align and > ntb_mw_count functions so that they always fail if the function is > called before the link is up. > > This is to prevent accidental mis-use in clients that are testing > on hardware that this doesn't

[PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

This patch adds a comment and a check to the ntb_mw_get_align and ntb_mw_count functions so that they always fail if the function is called before the link is up. This is to prevent accidental mis-use in clients that are testing on hardware that this doesn't matter for. Signed-off-by: Logan

[PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

This patch adds a comment and a check to the ntb_mw_get_align and ntb_mw_count functions so that they always fail if the function is called before the link is up. This is to prevent accidental mis-use in clients that are testing on hardware that this doesn't matter for. Signed-off-by: Logan