Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Joonsoo Kim
On Tue, Jul 30, 2013 at 11:19:58PM +0530, Aneesh Kumar K.V wrote: > Joonsoo Kim writes: > > > vma_need_reservation() can be substituted by vma_has_reserves() > > with minor change. These function do almost same thing, > > so unifying them is better to maintain. > > I found the resulting code

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Joonsoo Kim
Hello, Naoya. On Mon, Jul 29, 2013 at 01:52:52PM -0400, Naoya Horiguchi wrote: > Hi, > > On Mon, Jul 29, 2013 at 02:31:57PM +0900, Joonsoo Kim wrote: > > vma_need_reservation() can be substituted by vma_has_reserves() > > with minor change. These function do almost same thing, > > so unifying

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Aneesh Kumar K.V
Joonsoo Kim writes: > vma_need_reservation() can be substituted by vma_has_reserves() > with minor change. These function do almost same thing, > so unifying them is better to maintain. I found the resulting code confusing and complex. I am sure there is more that what is explained in the

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Aneesh Kumar K.V
Joonsoo Kim iamjoonsoo@lge.com writes: vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is better to maintain. I found the resulting code confusing and complex. I am sure there is more that what is

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Joonsoo Kim
Hello, Naoya. On Mon, Jul 29, 2013 at 01:52:52PM -0400, Naoya Horiguchi wrote: Hi, On Mon, Jul 29, 2013 at 02:31:57PM +0900, Joonsoo Kim wrote: vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-30 Thread Joonsoo Kim
On Tue, Jul 30, 2013 at 11:19:58PM +0530, Aneesh Kumar K.V wrote: Joonsoo Kim iamjoonsoo@lge.com writes: vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is better to maintain. I found the

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-29 Thread Naoya Horiguchi
Hi, On Mon, Jul 29, 2013 at 02:31:57PM +0900, Joonsoo Kim wrote: > vma_need_reservation() can be substituted by vma_has_reserves() > with minor change. These function do almost same thing, > so unifying them is better to maintain. I think it could, but not with minor changes. vma_has_reserves

Re: [PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-29 Thread Naoya Horiguchi
Hi, On Mon, Jul 29, 2013 at 02:31:57PM +0900, Joonsoo Kim wrote: vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is better to maintain. I think it could, but not with minor changes. vma_has_reserves is

[PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-28 Thread Joonsoo Kim
vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is better to maintain. Signed-off-by: Joonsoo Kim diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bf2ee11..ff46a2c 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c

[PATCH 06/18] mm, hugetlb: remove vma_need_reservation()

2013-07-28 Thread Joonsoo Kim
vma_need_reservation() can be substituted by vma_has_reserves() with minor change. These function do almost same thing, so unifying them is better to maintain. Signed-off-by: Joonsoo Kim iamjoonsoo@lge.com diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bf2ee11..ff46a2c 100644 ---