RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Yang, Wenyou
Hi Alexandre, > -Original Message- > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > Sent: Saturday, January 24, 2015 7:13 AM > To: Sylvain Rochet > Cc: Yang, Wenyou; Ferre, Nicolas; li...@arm.linux.org.uk; linux- > ker...@vger.kernel.org; p...@axentia.se;

RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-26 Thread Yang, Wenyou
Hi Alexandre, -Original Message- From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] Sent: Saturday, January 24, 2015 7:13 AM To: Sylvain Rochet Cc: Yang, Wenyou; Ferre, Nicolas; li...@arm.linux.org.uk; linux- ker...@vger.kernel.org; p...@axentia.se;

RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-25 Thread Yang, Wenyou
Hi Alexandre, Thank you for review. > -Original Message- > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > Sent: Saturday, January 24, 2015 7:02 AM > To: Sylvain Rochet > Cc: Yang, Wenyou; Ferre, Nicolas; li...@arm.linux.org.uk; linux- > ker...@vger.kernel.org;

RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-25 Thread Yang, Wenyou
Hi Sylvain, Thank you for review. > -Original Message- > From: Sylvain Rochet [mailto:sylvain.roc...@finsecur.com] > Sent: Saturday, January 24, 2015 1:33 AM > To: Yang, Wenyou > Cc: Ferre, Nicolas; li...@arm.linux.org.uk; linux-kernel@vger.kernel.org; >

RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-25 Thread Yang, Wenyou
Hi Alexandre, Thank you for review. -Original Message- From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] Sent: Saturday, January 24, 2015 7:02 AM To: Sylvain Rochet Cc: Yang, Wenyou; Ferre, Nicolas; li...@arm.linux.org.uk; linux- ker...@vger.kernel.org;

RE: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-25 Thread Yang, Wenyou
Hi Sylvain, Thank you for review. -Original Message- From: Sylvain Rochet [mailto:sylvain.roc...@finsecur.com] Sent: Saturday, January 24, 2015 1:33 AM To: Yang, Wenyou Cc: Ferre, Nicolas; li...@arm.linux.org.uk; linux-kernel@vger.kernel.org; alexandre.bell...@free-electrons.com;

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 23/01/2015 at 17:50:20 +0100, Sylvain Rochet wrote : > Hello Wenyou, > > > On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: > > > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > > index 691e6db..a1010f0 100644 > > --- a/arch/arm/mach-at91/pm.c > > +++

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 23/01/2015 at 18:32:34 +0100, Sylvain Rochet wrote : > Hello Wenyou, > > On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: > > > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > > index 691e6db..a1010f0 100644 > > --- a/arch/arm/mach-at91/pm.c > > +++

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Sylvain Rochet
Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index 691e6db..a1010f0 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c (...) > static int at91_pm_enter(suspend_state_t state)

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Sylvain Rochet
Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: > > diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c > index 691e6db..a1010f0 100644 > --- a/arch/arm/mach-at91/pm.c > +++ b/arch/arm/mach-at91/pm.c > @@ -145,62 +145,51 @@ extern void

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 20/01/2015 at 16:17:00 +0800, Wenyou Yang wrote : > To simply the PM code, the suspend to standby mode uses the same sram function > as the suspend to memory mode, running in the internal SRAM, > instead of the respective code for each mode. > > But for the suspend to standby mode, the master

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Sylvain Rochet
Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c (...) static int at91_pm_enter(suspend_state_t state) {

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Sylvain Rochet
Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c @@ -145,62 +145,51 @@ extern void at91_slow_clock(void

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 23/01/2015 at 17:50:20 +0100, Sylvain Rochet wrote : Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 23/01/2015 at 18:32:34 +0100, Sylvain Rochet wrote : Hello Wenyou, On Tue, Jan 20, 2015 at 04:17:00PM +0800, Wenyou Yang wrote: diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c index 691e6db..a1010f0 100644 --- a/arch/arm/mach-at91/pm.c +++ b/arch/arm/mach-at91/pm.c

Re: [PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-23 Thread Alexandre Belloni
On 20/01/2015 at 16:17:00 +0800, Wenyou Yang wrote : To simply the PM code, the suspend to standby mode uses the same sram function as the suspend to memory mode, running in the internal SRAM, instead of the respective code for each mode. But for the suspend to standby mode, the master clock

[PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-20 Thread Wenyou Yang
To simply the PM code, the suspend to standby mode uses the same sram function as the suspend to memory mode, running in the internal SRAM, instead of the respective code for each mode. But for the suspend to standby mode, the master clock doesn't switch to the slow clock, and the main

[PATCH 07/12] pm: at91: the standby mode uses the same sram function as the suspend to memory mode

2015-01-20 Thread Wenyou Yang
To simply the PM code, the suspend to standby mode uses the same sram function as the suspend to memory mode, running in the internal SRAM, instead of the respective code for each mode. But for the suspend to standby mode, the master clock doesn't switch to the slow clock, and the main