On Sun, Feb 24, 2008 at 12:31:17AM -0500, Christoph Hellwig wrote:
> On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
> > hm. We'll see how it plays out... on the remove side, the above is
> > exact what happens in gdth_remove_one() without my patch, thus
> > consolidating two
Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
> hm. We'll see how it plays out... on the remove side, the above is
> exact what happens in gdth_remove_one() without my patch, thus
> consolidating two cases of the same code into one. There is a less-strong
> argument for
Christoph Hellwig wrote:
Eventually we shoud just kill the INT_COAL ifdefed code. It has never
been enabled and clutters up the driver quite badly.
Noted (queued)... fine by me, and makes life easier.
+#ifdef CONFIG_EISA
+ if ((ha->type == GDT_EISA) && (ha->ccb_phys))
+
On Sat, Feb 23, 2008 at 11:44:44PM -0500, Jeff Garzik wrote:
> Several misc. cleanups:
>
> - remove recently-noop'd 'reverse_scan' module parm
>
> - remove pointless function prototypes
>
> - remove ha->pccb, its value always == >cmdext
>
> - move thrice-redundant DMA memory alloc and (in
Several misc. cleanups:
- remove recently-noop'd 'reverse_scan' module parm
- remove pointless function prototypes
- remove ha->pccb, its value always == >cmdext
- move thrice-redundant DMA memory alloc and (in EISA's case, mapping)
into common functions gdth_ha_alloc(), gdth_ha_free()
-
Several misc. cleanups:
- remove recently-noop'd 'reverse_scan' module parm
- remove pointless function prototypes
- remove ha-pccb, its value always == ha-cmdext
- move thrice-redundant DMA memory alloc and (in EISA's case, mapping)
into common functions gdth_ha_alloc(), gdth_ha_free()
-
On Sat, Feb 23, 2008 at 11:44:44PM -0500, Jeff Garzik wrote:
Several misc. cleanups:
- remove recently-noop'd 'reverse_scan' module parm
- remove pointless function prototypes
- remove ha-pccb, its value always == ha-cmdext
- move thrice-redundant DMA memory alloc and (in EISA's case,
Christoph Hellwig wrote:
Eventually we shoud just kill the INT_COAL ifdefed code. It has never
been enabled and clutters up the driver quite badly.
Noted (queued)... fine by me, and makes life easier.
+#ifdef CONFIG_EISA
+ if ((ha-type == GDT_EISA) (ha-ccb_phys))
+
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a less-strong
argument for doing
Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases of the same code into one. There is a
On Sun, Feb 24, 2008 at 12:31:17AM -0500, Christoph Hellwig wrote:
On Sun, Feb 24, 2008 at 12:18:23AM -0500, Jeff Garzik wrote:
hm. We'll see how it plays out... on the remove side, the above is
exact what happens in gdth_remove_one() without my patch, thus
consolidating two cases
12 matches
Mail list logo
