Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-07 Thread Mauro Carvalho Chehab
> > Seem that something in git-dvb (or mainline) broke this driver: > > > > drivers/media/video/stk11xx-core.c: In function 'show_contrast': > > drivers/media/video/stk11xx-core.c:707: warning: initialization from > > incompatible pointer type > > drivers/media/video/stk11xx-core.c: In function

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-07 Thread Mauro Carvalho Chehab
Seem that something in git-dvb (or mainline) broke this driver: drivers/media/video/stk11xx-core.c: In function 'show_contrast': drivers/media/video/stk11xx-core.c:707: warning: initialization from incompatible pointer type drivers/media/video/stk11xx-core.c: In function

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-06 Thread Jiri Slaby
Andrew Morton napsal(a): > On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> stk11xx, add a new webcam driver >> >> Adds support for stk1125, stk1135 and stkdcnew webcam built-in some >> notebooks. > > Seem that something in git-dvb (or mainline) broke this driver: >

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-06 Thread Jiri Slaby
Andrew Morton napsal(a): On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby [EMAIL PROTECTED] wrote: stk11xx, add a new webcam driver Adds support for stk1125, stk1135 and stkdcnew webcam built-in some notebooks. Seem that something in git-dvb (or mainline) broke this driver:

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-05 Thread Andrew Morton
On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby <[EMAIL PROTECTED]> wrote: > stk11xx, add a new webcam driver > > Adds support for stk1125, stk1135 and stkdcnew webcam built-in some > notebooks. Seem that something in git-dvb (or mainline) broke this driver: drivers/media/video/stk11xx-core.c:

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-11-05 Thread Andrew Morton
On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby [EMAIL PROTECTED] wrote: stk11xx, add a new webcam driver Adds support for stk1125, stk1135 and stkdcnew webcam built-in some notebooks. Seem that something in git-dvb (or mainline) broke this driver: drivers/media/video/stk11xx-core.c: In

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-28 Thread Alexander E. Patrakov
Jiri Slaby wrote: + /* From 80x60 to 640x480 */ + const u8 values_1_204[] = { + 0x12, 0x11, 0x3b, 0x6a, 0x13, 0x10, 0x00, 0x01, 0x02, 0x13, + 0x39, 0x38, 0x37, 0x35, 0x0e, 0x12, 0x04, 0x0c, 0x0d, 0x17, + 0x18, 0x32, 0x19, 0x1a, 0x03, 0x1b,

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-28 Thread Alexander E. Patrakov
Jiri Slaby wrote: + /* From 80x60 to 640x480 */ + const u8 values_1_204[] = { + 0x12, 0x11, 0x3b, 0x6a, 0x13, 0x10, 0x00, 0x01, 0x02, 0x13, + 0x39, 0x38, 0x37, 0x35, 0x0e, 0x12, 0x04, 0x0c, 0x0d, 0x17, + 0x18, 0x32, 0x19, 0x1a, 0x03, 0x1b,

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Jiri Slaby
Andrew Morton napsal(a): > On Tue, 28 Aug 2007 07:33:08 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: > >>> Again, ARRAY_SIZE() would be clearer here. >> No, this is only do this 16 times, no corresponding table :). > > OK, poorly chosen example. But there are lots of others, like: Yes, you

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Andrew Morton
On Tue, 28 Aug 2007 07:33:08 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: > > Again, ARRAY_SIZE() would be clearer here. > > No, this is only do this 16 times, no corresponding table :). OK, poorly chosen example. But there are lots of others, like: + + for (i = 0; i < 59; i++) { +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Jiri Slaby
Andrew Morton napsal(a): > On Sun, 26 Aug 2007 07:09:02 -0700 > Jiri Slaby <[EMAIL PROTECTED]> wrote: > + retok = stk11xx_check_device(dev, 500); > + if (retok != 1) { > + dev_err(>udev->dev, "load microcode fail\n"); > + return -EIO;

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Andrew Morton
On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby <[EMAIL PROTECTED]> wrote: > Hi, > > is it possible to have this driver in the -mm tree for testing purposes until > v4l library will be developped and image resize with bayer->rgb conversion > will be moved there? (Then, I'll push it through v4l

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Andrew Morton
On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby [EMAIL PROTECTED] wrote: Hi, is it possible to have this driver in the -mm tree for testing purposes until v4l library will be developped and image resize with bayer-rgb conversion will be moved there? (Then, I'll push it through v4l people.)

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Andrew Morton
On Tue, 28 Aug 2007 07:33:08 +0200 Jiri Slaby [EMAIL PROTECTED] wrote: Again, ARRAY_SIZE() would be clearer here. No, this is only do this 16 times, no corresponding table :). OK, poorly chosen example. But there are lots of others, like: + + for (i = 0; i 59; i++) { +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Jiri Slaby
Andrew Morton napsal(a): On Tue, 28 Aug 2007 07:33:08 +0200 Jiri Slaby [EMAIL PROTECTED] wrote: Again, ARRAY_SIZE() would be clearer here. No, this is only do this 16 times, no corresponding table :). OK, poorly chosen example. But there are lots of others, like: Yes, you mentioned them

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-08-27 Thread Jiri Slaby
Andrew Morton napsal(a): On Sun, 26 Aug 2007 07:09:02 -0700 Jiri Slaby [EMAIL PROTECTED] wrote: + retok = stk11xx_check_device(dev, 500); + if (retok != 1) { + dev_err(dev-udev-dev, load microcode fail\n); + return -EIO; +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-19 Thread Jiri Slaby
Oliver Neukum napsal(a): > Am Freitag, 15. Juni 2007 schrieb Jiri Slaby: >> +struct stk11xx_frame_buf { >> + void *data; >> + volatile int filled; >> + struct stk11xx_frame_buf *next; >> +}; >> + > > What's the "volatile" doing here? removed (s/volatile/unsigned/), thanks, --

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-19 Thread Jiri Slaby
Oliver Neukum napsal(a): Am Freitag, 15. Juni 2007 schrieb Jiri Slaby: +struct stk11xx_frame_buf { + void *data; + volatile int filled; + struct stk11xx_frame_buf *next; +}; + What's the volatile doing here? removed (s/volatile/unsigned/), thanks, --

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-16 Thread Jiri Slaby
Thierry Merle napsal(a): > Le vendredi 15 juin 2007 à 23:08 +0200, Jiri Slaby a écrit : >> Mauro Carvalho Chehab wrote: >>> Em Sáb, 2007-06-02 à s 11:00 +0200, Thierry Merle escreveu: Nevertheless, I will start to specify the framework. The helper daemon would link to the v4l2-apps/lib.

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-16 Thread Thierry Merle
Le vendredi 15 juin 2007 à 23:08 +0200, Jiri Slaby a écrit : > Mauro Carvalho Chehab wrote: > > Em Sáb, 2007-06-02 à s 11:00 +0200, Thierry Merle escreveu: > > > > > > Mauro Carvalho Chehab a écrit : > > > >>> This seems to be an interesting approach. > > > >>> > > > >>> > > > >>> > >

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-16 Thread Thierry Merle
Le vendredi 15 juin 2007 à 23:08 +0200, Jiri Slaby a écrit : Mauro Carvalho Chehab wrote: Em Sáb, 2007-06-02 à s 11:00 +0200, Thierry Merle escreveu: Mauro Carvalho Chehab a écrit : This seems to be an interesting approach. Interesting but impossible to do

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-16 Thread Jiri Slaby
Thierry Merle napsal(a): Le vendredi 15 juin 2007 à 23:08 +0200, Jiri Slaby a écrit : Mauro Carvalho Chehab wrote: Em Sáb, 2007-06-02 à s 11:00 +0200, Thierry Merle escreveu: Nevertheless, I will start to specify the framework. The helper daemon would link to the v4l2-apps/lib. Ok, thanks!

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-04 Thread Mauro Carvalho Chehab
Em Sáb, 2007-06-02 às 11:00 +0200, Thierry Merle escreveu: > > Mauro Carvalho Chehab a écrit : > >>> This seems to be an interesting approach. > >>> > >>> > >>> > >> Interesting but impossible to do for ioctl calls. > >> When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,)

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-04 Thread Mauro Carvalho Chehab
Em Sáb, 2007-06-02 às 11:00 +0200, Thierry Merle escreveu: Mauro Carvalho Chehab a écrit : This seems to be an interesting approach. Interesting but impossible to do for ioctl calls. When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,arg) for example, there

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-02 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : This seems to be an interesting approach. Interesting but impossible to do for ioctl calls. When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,) for example, there is no way for the userspace helper to catch this ioctl. The application

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-02 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : This seems to be an interesting approach. Interesting but impossible to do for ioctl calls. When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,arg) for example, there is no way for the userspace helper to catch this ioctl. The

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-01 Thread Mauro Carvalho Chehab
> > This seems to be an interesting approach. > > > > > Interesting but impossible to do for ioctl calls. > When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,) > for example, there is no way for the userspace helper to catch this ioctl. > The application could only open/read

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-01 Thread Mauro Carvalho Chehab
> >> + * Copyright (C) Nicolas VIVIEN > > > > It would be interesting to have Nicolas SOB as well, if possible. > > I don't think he ever knows about this version of the driver. I got his GPL > driver, cleaned up -- coding style, v4l1 and v4l2 ioctl conversion to v4l2 > functions, some bug

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-01 Thread Mauro Carvalho Chehab
+ * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. I don't think he ever knows about this version of the driver. I got his GPL driver, cleaned up -- coding style, v4l1 and v4l2 ioctl conversion to v4l2 functions, some bug fixes and so

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-06-01 Thread Mauro Carvalho Chehab
This seems to be an interesting approach. Interesting but impossible to do for ioctl calls. When the application does a ioctl(fd_of_mnt_video0,VIDIOC_G_FMT,arg) for example, there is no way for the userspace helper to catch this ioctl. The application could only open/read from the

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-31 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : Em Ter, 2007-05-29 às 21:04 +0200, Thierry Merle escreveu: Mauro Carvalho Chehab a écrit : Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-31 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : Em Ter, 2007-05-29 às 21:04 +0200, Thierry Merle escreveu: Mauro Carvalho Chehab a écrit : Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-30 Thread Jiri Slaby
Mauro Carvalho Chehab napsal(a): > Hi Jiri, Hi. > I have some comments for your driver. Well, that was exactly what the code needed, yet another eyes. >> + * Copyright (C) Nicolas VIVIEN > > It would be interesting to have Nicolas SOB as well, if possible. I don't think he ever knows about

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-30 Thread Jiri Slaby
Mauro Carvalho Chehab napsal(a): Hi Jiri, Hi. I have some comments for your driver. Well, that was exactly what the code needed, yet another eyes. + * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. I don't think he ever knows about this

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Mauro Carvalho Chehab
Em Ter, 2007-05-29 às 21:04 +0200, Thierry Merle escreveu: > > Mauro Carvalho Chehab a écrit : > > > > > >>> Hi Mauro and Markus, > >>> Just to summ up what I understood we need: > >>> > >>> What do we need in userspace, only for v4l (dvb is not concerned): > >>> - colorspace translations >

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace translations - filters that be done in hardware if the selected hardware can, otherwise software plugin -

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Mauro Carvalho Chehab
> > Hi Mauro and Markus, > > Just to summ up what I understood we need: > > > > What do we need in userspace, only for v4l (dvb is not concerned): > > - colorspace translations > > - filters that be done in hardware if the selected hardware can, > > otherwise software plugin > > -

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Mauro Carvalho Chehab
Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace translations - filters that be done in hardware if the selected hardware can, otherwise software plugin - decompression algorithm like

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace translations - filters that be done in hardware if the selected hardware can, otherwise software plugin -

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-29 Thread Mauro Carvalho Chehab
Em Ter, 2007-05-29 às 21:04 +0200, Thierry Merle escreveu: Mauro Carvalho Chehab a écrit : Hi Mauro and Markus, Just to summ up what I understood we need: What do we need in userspace, only for v4l (dvb is not concerned): - colorspace translations - filters that be done in

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Thierry Merle
Thierry Merle a écrit : Mauro Carvalho Chehab a écrit : As Luca pointed, if we add conversion for one driver, we should add for the rest. Instead, it would be better if Jiri sends the decoding and the rescaling stuff as a patch to v4l2-apps/lib, starting the API decoding library. Once we

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : As Luca pointed, if we add conversion for one driver, we should add for the rest. Instead, it would be better if Jiri sends the decoding and the rescaling stuff as a patch to v4l2-apps/lib, starting the API decoding library. Once we have a library, we can ask the

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
> > As Luca pointed, if we add conversion for one driver, we should add for > > the rest. > > > > Instead, it would be better if Jiri sends the decoding and the rescaling > > stuff as a patch to v4l2-apps/lib, starting the API decoding library. > > Once we have a library, we can ask the userspace

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: Em Seg, 2007-05-28 às 17:14 +0200, Markus Rechberger escreveu: > > > +/* > > > + * Bayer conversion > > > + */ > > > > We don't do format conversions in kernel. Instead, you should return a > > proper Bayer Fourcc format (like

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
Em Seg, 2007-05-28 às 17:14 +0200, Markus Rechberger escreveu: > > > +/* > > > + * Bayer conversion > > > + */ > > > > We don't do format conversions in kernel. Instead, you should return a > > proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8). > > > > It's ok in his case since most

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Luca Risolia <[EMAIL PROTECTED]> wrote: On Monday 28 May 2007 17:14:51 Markus Rechberger wrote: > On 5/28/07, Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: > > We don't do format conversions in kernel. Instead, you should return a > > proper Bayer Fourcc format (like

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Luca Risolia
On Monday 28 May 2007 17:14:51 Markus Rechberger wrote: > On 5/28/07, Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: > > We don't do format conversions in kernel. Instead, you should return a > > proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8). > > It's ok in his case since most userspace

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: On 5/24/07, Markus Rechberger <[EMAIL PROTECTED]> wrote: > Hi Jiri, > > On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > > Well, no objections on v4l list, try to merge it. Any further comments will > > be > > appreciated. > > > > -- > > > >

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: Hi Jiri, I have some comments for your driver. > + * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. > + > +#ifndef CONFIG_STK11XX_DEBUG_STREAM > +#define CONFIG_STK11XX_DEBUG_STREAM

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
Hi Jiri, I have some comments for your driver. > + * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. > + > +#ifndef CONFIG_STK11XX_DEBUG_STREAM > +#define CONFIG_STK11XX_DEBUG_STREAM 0 > +#endif > + > +#if CONFIG_STK11XX_DEBUG_STREAM I would

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
Hi Jiri, I have some comments for your driver. + * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. + +#ifndef CONFIG_STK11XX_DEBUG_STREAM +#define CONFIG_STK11XX_DEBUG_STREAM 0 +#endif + +#if CONFIG_STK11XX_DEBUG_STREAM I would instead

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: Hi Jiri, I have some comments for your driver. + * Copyright (C) Nicolas VIVIEN It would be interesting to have Nicolas SOB as well, if possible. + +#ifndef CONFIG_STK11XX_DEBUG_STREAM +#define CONFIG_STK11XX_DEBUG_STREAM 0

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: On 5/24/07, Markus Rechberger [EMAIL PROTECTED] wrote: Hi Jiri, On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: Well, no objections on v4l list, try to merge it. Any further comments will be appreciated. -- stk11xx, add a new

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Luca Risolia [EMAIL PROTECTED] wrote: On Monday 28 May 2007 17:14:51 Markus Rechberger wrote: On 5/28/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: We don't do format conversions in kernel. Instead, you should return a proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8).

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Luca Risolia
On Monday 28 May 2007 17:14:51 Markus Rechberger wrote: On 5/28/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: We don't do format conversions in kernel. Instead, you should return a proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8). It's ok in his case since most userspace

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
Em Seg, 2007-05-28 às 17:14 +0200, Markus Rechberger escreveu: +/* + * Bayer conversion + */ We don't do format conversions in kernel. Instead, you should return a proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8). It's ok in his case since most userspace applications do

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Markus Rechberger
On 5/28/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: Em Seg, 2007-05-28 às 17:14 +0200, Markus Rechberger escreveu: +/* + * Bayer conversion + */ We don't do format conversions in kernel. Instead, you should return a proper Bayer Fourcc format (like V4L2_PIX_FMT_SBGGR8).

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Mauro Carvalho Chehab
As Luca pointed, if we add conversion for one driver, we should add for the rest. Instead, it would be better if Jiri sends the decoding and the rescaling stuff as a patch to v4l2-apps/lib, starting the API decoding library. Once we have a library, we can ask the userspace developers

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Thierry Merle
Mauro Carvalho Chehab a écrit : As Luca pointed, if we add conversion for one driver, we should add for the rest. Instead, it would be better if Jiri sends the decoding and the rescaling stuff as a patch to v4l2-apps/lib, starting the API decoding library. Once we have a library, we can ask the

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-28 Thread Thierry Merle
Thierry Merle a écrit : Mauro Carvalho Chehab a écrit : As Luca pointed, if we add conversion for one driver, we should add for the rest. Instead, it would be better if Jiri sends the decoding and the rescaling stuff as a patch to v4l2-apps/lib, starting the API decoding library. Once we

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Jiri Slaby wrote: > On 5/25/07, Stefan Richter <[EMAIL PROTECTED]> wrote: >> Ismail Dönmez wrote: >> > On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: >> >> Maybe this is a too picky requeriment, but IMO it would be nice if the >> >> module would be called "camera_stk11xx", or had any other

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Jiri Slaby
On 5/25/07, Stefan Richter <[EMAIL PROTECTED]> wrote: Jiri Slaby wrote: > On 5/24/07, Markus Rechberger <[EMAIL PROTECTED]> wrote: >> On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > [...] >> > +static int stk1125_camera_asleep(struct stk11xx *dev) >> > +{ >> > + int value; >> > + >> > +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Jiri Slaby wrote: > On 5/24/07, Markus Rechberger <[EMAIL PROTECTED]> wrote: >> On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > [...] >> > +static int stk1125_camera_asleep(struct stk11xx *dev) >> > +{ >> > + int value; >> > + >> > + stk11xx_read_registry(dev, 0x0104, ); >> > +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Ismail Dönmez wrote: > On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: >> El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby <[EMAIL PROTECTED]> > escribió: >> > +config USB_STK11XX >> > + tristate "STK11XX based webcams" >> > + depends on VIDEO_V4L2 >> > + ---help--- >> > +This

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Ismail Dönmez wrote: On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby [EMAIL PROTECTED] escribió: +config USB_STK11XX + tristate STK11XX based webcams + depends on VIDEO_V4L2 + ---help--- +This will add support for

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Jiri Slaby wrote: On 5/24/07, Markus Rechberger [EMAIL PROTECTED] wrote: On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: [...] +static int stk1125_camera_asleep(struct stk11xx *dev) +{ + int value; + + stk11xx_read_registry(dev, 0x0104, value); +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Jiri Slaby
On 5/25/07, Stefan Richter [EMAIL PROTECTED] wrote: Jiri Slaby wrote: On 5/24/07, Markus Rechberger [EMAIL PROTECTED] wrote: On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: [...] +static int stk1125_camera_asleep(struct stk11xx *dev) +{ + int value; + +

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-25 Thread Stefan Richter
Jiri Slaby wrote: On 5/25/07, Stefan Richter [EMAIL PROTECTED] wrote: Ismail Dönmez wrote: On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: Maybe this is a too picky requeriment, but IMO it would be nice if the module would be called camera_stk11xx, or had any other prefix that

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Jiri Slaby
On 5/24/07, Markus Rechberger <[EMAIL PROTECTED]> wrote: Hi Jiri, On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > Well, no objections on v4l list, try to merge it. Any further comments will > be > appreciated. > > -- > > stk11xx, add a new webcam driver [...] > +static int

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Ismail Dönmez
On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: > El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby <[EMAIL PROTECTED]> escribió: > > +config USB_STK11XX > > + tristate "STK11XX based webcams" > > + depends on VIDEO_V4L2 > > + ---help--- > > + This will add support for Syntek

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Diego Calleja
El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby <[EMAIL PROTECTED]> escribió: > +config USB_STK11XX > + tristate "STK11XX based webcams" > + depends on VIDEO_V4L2 > + ---help--- > + This will add support for Syntek webcams such as dc1125 and stk1135. > + > + If you

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Jiri Slaby
On 5/24/07, Markus Rechberger <[EMAIL PROTECTED]> wrote: Hi Jiri, On 5/24/07, Jiri Slaby <[EMAIL PROTECTED]> wrote: > Well, no objections on v4l list, try to merge it. Any further comments will > be > appreciated. > > -- > > stk11xx, add a new webcam driver > > Cc: Mauro Carvalho Chehab <[EMAIL

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Jiri Slaby
On 5/24/07, Markus Rechberger [EMAIL PROTECTED] wrote: Hi Jiri, On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: Well, no objections on v4l list, try to merge it. Any further comments will be appreciated. -- stk11xx, add a new webcam driver Cc: Mauro Carvalho Chehab [EMAIL PROTECTED]

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Diego Calleja
El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby [EMAIL PROTECTED] escribió: +config USB_STK11XX + tristate STK11XX based webcams + depends on VIDEO_V4L2 + ---help--- + This will add support for Syntek webcams such as dc1125 and stk1135. + + If you choose to

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Ismail Dönmez
On Thursday 24 May 2007 20:38:05 Diego Calleja wrote: El Thu, 24 May 2007 16:01:33 +0200 (CEST), Jiri Slaby [EMAIL PROTECTED] escribió: +config USB_STK11XX + tristate STK11XX based webcams + depends on VIDEO_V4L2 + ---help--- + This will add support for Syntek webcams such as

Re: [PATCH 1/1] V4L: stk11xx, add a new webcam driver

2007-05-24 Thread Jiri Slaby
On 5/24/07, Markus Rechberger [EMAIL PROTECTED] wrote: Hi Jiri, On 5/24/07, Jiri Slaby [EMAIL PROTECTED] wrote: Well, no objections on v4l list, try to merge it. Any further comments will be appreciated. -- stk11xx, add a new webcam driver [...] +static int