On Wed, 2015-04-01 at 14:17 +0200, Jonas Gorski wrote:
> On Tue, Jun 24, 2014 at 9:26 PM, Florian Fainelli wrote:
> > 2014-06-24 8:48 GMT-07:00 Joe Perches :
> >> On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
> >>> Replace sscanf() with mac_pton().
> >> []
> >>> diff --git
On Wed, Apr 01, 2015 at 02:17:16PM +0200, Jonas Gorski wrote:
>for (i = 0; i < 6; i++)
>dev_addr[i] = (char2hex(mac[i * 3]) << 4) +
>char2hex(mac[i * 3 + 1]);
>
>
> So I'm tempted to say it should not cause any issues. But my sample
> size is
On Tue, Jun 24, 2014 at 9:26 PM, Florian Fainelli wrote:
> 2014-06-24 8:48 GMT-07:00 Joe Perches :
>> On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
>>> Replace sscanf() with mac_pton().
>> []
>>> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
>> []
>>> @@ -307,10
On Tue, Jun 24, 2014 at 9:26 PM, Florian Fainelli flor...@openwrt.org wrote:
2014-06-24 8:48 GMT-07:00 Joe Perches j...@perches.com:
On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
Replace sscanf() with mac_pton().
[]
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
On Wed, Apr 01, 2015 at 02:17:16PM +0200, Jonas Gorski wrote:
for (i = 0; i 6; i++)
dev_addr[i] = (char2hex(mac[i * 3]) 4) +
char2hex(mac[i * 3 + 1]);
So I'm tempted to say it should not cause any issues. But my sample
size is rather small.
On Wed, 2015-04-01 at 14:17 +0200, Jonas Gorski wrote:
On Tue, Jun 24, 2014 at 9:26 PM, Florian Fainelli flor...@openwrt.org wrote:
2014-06-24 8:48 GMT-07:00 Joe Perches j...@perches.com:
On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
Replace sscanf() with mac_pton().
[]
diff
2014-06-24 8:48 GMT-07:00 Joe Perches :
> On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
>> Replace sscanf() with mac_pton().
> []
>> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
> []
>> @@ -307,10 +307,7 @@ static void __init cpmac_get_mac(int instance, unsigned
>>
On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
> Replace sscanf() with mac_pton().
[]
> diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
[]
> @@ -307,10 +307,7 @@ static void __init cpmac_get_mac(int instance, unsigned
> char *dev_addr)
> }
>
> if (mac) {
>
Replace sscanf() with mac_pton().
Signed-off-by: Daniel Walter
---
arch/mips/ar7/platform.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
index 7e2356f..653cbff 100644
--- a/arch/mips/ar7/platform.c
+++
Replace sscanf() with mac_pton().
Signed-off-by: Daniel Walter dwal...@google.com
---
arch/mips/ar7/platform.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
---
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
index 7e2356f..653cbff 100644
---
On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
Replace sscanf() with mac_pton().
[]
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
[]
@@ -307,10 +307,7 @@ static void __init cpmac_get_mac(int instance, unsigned
char *dev_addr)
}
if (mac) {
-
2014-06-24 8:48 GMT-07:00 Joe Perches j...@perches.com:
On Tue, 2014-06-24 at 16:39 +0100, Daniel Walter wrote:
Replace sscanf() with mac_pton().
[]
diff --git a/arch/mips/ar7/platform.c b/arch/mips/ar7/platform.c
[]
@@ -307,10 +307,7 @@ static void __init cpmac_get_mac(int instance,
12 matches
Mail list logo