Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Benny Halevy <[EMAIL PROTECTED]> wrote: > > I was trying to say that the methods should be compatible, otherwise > bugs can happen, and that your scheme is better since it can > handle sglists with zero length entries that aren't the last. > A case that might be valid after dma mapping and

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Benny Halevy [EMAIL PROTECTED] wrote: I was trying to say that the methods should be compatible, otherwise bugs can happen, and that your scheme is better since it can handle sglists with zero length entries that aren't the last. A case that might be valid after dma mapping and merging. If

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Jens Axboe wrote: > On Thu, May 10 2007, Benny Halevy wrote: >> Jens Axboe wrote: >>> It's a subsystem function, prefix it as such. >> Jens, Boaz and I talked about this over lunch. >> I wonder whether the crypto code must use your implementation >> instead of its own as it needs to over the

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

On Thu, May 10 2007, Benny Halevy wrote: > Jens Axboe wrote: > > It's a subsystem function, prefix it as such. > > Jens, Boaz and I talked about this over lunch. > I wonder whether the crypto code must use your implementation > instead of its own as it needs to over the sglist, e.g. for >

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Jens Axboe wrote: > It's a subsystem function, prefix it as such. Jens, Boaz and I talked about this over lunch. I wonder whether the crypto code must use your implementation instead of its own as it needs to over the sglist, e.g. for calculating iscsi (data) digest. The crypto implementation of

[PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

It's a subsystem function, prefix it as such. Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> --- crypto/digest.c |2 +- crypto/scatterwalk.c |2 +- crypto/scatterwalk.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/digest.c b/crypto/digest.c index

[PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

It's a subsystem function, prefix it as such. Signed-off-by: Jens Axboe [EMAIL PROTECTED] --- crypto/digest.c |2 +- crypto/scatterwalk.c |2 +- crypto/scatterwalk.h |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/digest.c b/crypto/digest.c index

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Jens Axboe wrote: It's a subsystem function, prefix it as such. Jens, Boaz and I talked about this over lunch. I wonder whether the crypto code must use your implementation instead of its own as it needs to over the sglist, e.g. for calculating iscsi (data) digest. The crypto implementation of

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

On Thu, May 10 2007, Benny Halevy wrote: Jens Axboe wrote: It's a subsystem function, prefix it as such. Jens, Boaz and I talked about this over lunch. I wonder whether the crypto code must use your implementation instead of its own as it needs to over the sglist, e.g. for calculating

Re: [PATCH 1/12] crypto: don't pollute the global namespace with sg_next()

Jens Axboe wrote: On Thu, May 10 2007, Benny Halevy wrote: Jens Axboe wrote: It's a subsystem function, prefix it as such. Jens, Boaz and I talked about this over lunch. I wonder whether the crypto code must use your implementation instead of its own as it needs to over the sglist, e.g. for