Hi Dan,
Am Dienstag, den 07.01.2014, 15:45 +0300 schrieb Dan Carpenter:
> Oops sorry... I'm also still catching up from the holidays. I think I
> was even CC'd on your earlier fix.
No problem. Let me send my latest set of patches for our GenWQE driver
which includes the ioctl return code fix
Oops sorry... I'm also still catching up from the holidays. I think I
was even CC'd on your earlier fix.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Dan,
Am Dienstag, den 07.01.2014, 09:41 +0300 schrieb Dan Carpenter:
> Could you also fix this Smatch warning?
> drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return
> -EFAULT instead of the bytes remaining?
I thought i fixed this already in my posting:
[PATCH] GenWQE:
Hi Dan,
Am Dienstag, den 07.01.2014, 09:41 +0300 schrieb Dan Carpenter:
Could you also fix this Smatch warning?
drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return
-EFAULT instead of the bytes remaining?
I thought i fixed this already in my posting:
[PATCH] GenWQE:
Oops sorry... I'm also still catching up from the holidays. I think I
was even CC'd on your earlier fix.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hi Dan,
Am Dienstag, den 07.01.2014, 15:45 +0300 schrieb Dan Carpenter:
Oops sorry... I'm also still catching up from the holidays. I think I
was even CC'd on your earlier fix.
No problem. Let me send my latest set of patches for our GenWQE driver
which includes the ioctl return code fix and
Could you also fix this Smatch warning?
drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return -EFAULT
instead of the bytes remaining?
Also we shouldn't be doing dev_err() on copy_to/from_user() problems.
The user can trigger those and flood dmesg. It is a DoS (annoying).
Could you also fix this Smatch warning?
drivers/misc/genwqe/card_dev.c:658 do_flash_update() warn: maybe return -EFAULT
instead of the bytes remaining?
Also we shouldn't be doing dev_err() on copy_to/from_user() problems.
The user can trigger those and flood dmesg. It is a DoS (annoying).
Hi Greg,
Am Freitag, den 20.12.2013, 16:26 +0100 schrieb Frank Haverkamp:
> +++ b/drivers/misc/genwqe/card_utils.c
> @@ -59,7 +59,7 @@ int __genwqe_writeq(struct genwqe_dev *c
> if (cd->mmio == NULL)
> return -EIO;
>
> - __raw_writeq(cpu_to_be64((val)), (cd->mmio +
On Fri, Dec 20, 2013 at 04:26:10PM +0100, Frank Haverkamp wrote:
> Fengguang Wu used CF=-D__CHECK_ENDIAN__ to check the GenWQE driver for
> endian issues. Sparse found a couple of those. Most of them were caused
> by not correctly handling __be64/32 and __u64/32. Those I was able to
> fix with
Fengguang Wu used CF=-D__CHECK_ENDIAN__ to check the GenWQE driver for
endian issues. Sparse found a couple of those. Most of them were caused
by not correctly handling __be64/32 and __u64/32. Those I was able to
fix with appropriate castings.
One more serious issue was the ATS entry in struct
Fengguang Wu used CF=-D__CHECK_ENDIAN__ to check the GenWQE driver for
endian issues. Sparse found a couple of those. Most of them were caused
by not correctly handling __be64/32 and __u64/32. Those I was able to
fix with appropriate castings.
One more serious issue was the ATS entry in struct
On Fri, Dec 20, 2013 at 04:26:10PM +0100, Frank Haverkamp wrote:
Fengguang Wu used CF=-D__CHECK_ENDIAN__ to check the GenWQE driver for
endian issues. Sparse found a couple of those. Most of them were caused
by not correctly handling __be64/32 and __u64/32. Those I was able to
fix with
Hi Greg,
Am Freitag, den 20.12.2013, 16:26 +0100 schrieb Frank Haverkamp:
+++ b/drivers/misc/genwqe/card_utils.c
@@ -59,7 +59,7 @@ int __genwqe_writeq(struct genwqe_dev *c
if (cd-mmio == NULL)
return -EIO;
- __raw_writeq(cpu_to_be64((val)), (cd-mmio +
14 matches
Mail list logo
