Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-30 Thread David Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Fri, 21 Sep 2007 19:47:17 -0700 > On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote: > > From: Denys Vlasenko <[EMAIL PROTECTED]> > > Date: Fri, 21 Sep 2007 18:03:55 +0100 > > > > > Do patches look ok to you? > > > > I'm travelling so I haven't

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-30 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 19:47:17 -0700 On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-24 Thread Kyle Moffett
On Sep 24, 2007, at 13:32:23, Lennart Sorensen wrote: On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote: But I compile net/* into bzImage. I like netbooting :) Isn't it possible to netboot with an initramfs image? I am pretty sure I have seen some systems do exactly that.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-24 Thread Lennart Sorensen
On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote: > But I compile net/* into bzImage. I like netbooting :) Isn't it possible to netboot with an initramfs image? I am pretty sure I have seen some systems do exactly that. -- Len Sorensen - To unsubscribe from this list: send the

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-24 Thread Lennart Sorensen
On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote: But I compile net/* into bzImage. I like netbooting :) Isn't it possible to netboot with an initramfs image? I am pretty sure I have seen some systems do exactly that. -- Len Sorensen - To unsubscribe from this list: send the line

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-24 Thread Kyle Moffett
On Sep 24, 2007, at 13:32:23, Lennart Sorensen wrote: On Fri, Sep 21, 2007 at 11:37:52PM +0100, Denys Vlasenko wrote: But I compile net/* into bzImage. I like netbooting :) Isn't it possible to netboot with an initramfs image? I am pretty sure I have seen some systems do exactly that.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Michael Chan
On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote: > From: Denys Vlasenko <[EMAIL PROTECTED]> > Date: Fri, 21 Sep 2007 18:03:55 +0100 > > > Do patches look ok to you? > > I'm travelling so I haven't looked closely yet :-) > > Michael can take a look and I'll try to do so as well > tonight.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread maximilian attems
On Fri, Sep 21, 2007 at 11:48:05PM +0100, Alan Cox wrote: > > According to an earlier thread, dgrs was never really maintained, > > written for hardware that was never really distributed widely, and very > > likely hasn't had users in years... if ever. > > > > If that picture is accurate (it's

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Denys Vlasenko wrote: On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
> According to an earlier thread, dgrs was never really maintained, > written for hardware that was never really distributed widely, and very > likely hasn't had users in years... if ever. > > If that picture is accurate (it's a story I was told), then I am > definitely queueing up a deletion

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: > > On Fri, 21 Sep 2007, Denys Vlasenko wrote: > > > On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: > >> On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: > >> > >>> I plan to use gzip compression on following drivers'

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 21:13, Andi Kleen wrote: > Denys Vlasenko <[EMAIL PROTECTED]> writes: > > > > I plan to use gzip compression on following drivers' firmware, > > if patches will be accepted: > > > >textdata bss dec hex filename > > 17653 109968 240 127861

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Alan Cox wrote: For example, bnx2 maintainer says that driver and firmware are closely tied for his driver. IOW: you upgrade kernel and your NIC is not working anymore. Another argument is to make kernel be able to bring up NICs without needing firmware images in initramfs/initrd/hard drive.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
> For example, bnx2 maintainer says that driver and > firmware are closely tied for his driver. IOW: you upgrade kernel > and your NIC is not working anymore. > > Another argument is to make kernel be able to bring up NICs > without needing firmware images in initramfs/initrd/hard drive. dgrs

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Roland Dreier
> Just change the makefiles to always install gzip'ed modules > modutils knows how to unzip them on the fly. But that leaves the uncompressed firmware blobs in .data that ends up in unswappable kernel memory. - R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Andi Kleen
Denys Vlasenko <[EMAIL PROTECTED]> writes: > > I plan to use gzip compression on following drivers' firmware, > if patches will be accepted: > >textdata bss dec hex filename > 17653 109968 240 127861 1f375 drivers/net/acenic.o >6628 120448 4 127080

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Krzysztof Oledzki
On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 20:18:06 BST, Denys Vlasenko said: > On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: > > Should this be redone to use the existing firmware loading framework to > > load the firmware instead? > > Not in every case. > > For example, bnx2 maintainer says that driver

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: > On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: > > > I plan to use gzip compression on following drivers' firmware, > > if patches will be accepted: > > > >textdata bss dec hex filename > > 17653 109968

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: > I plan to use gzip compression on following drivers' firmware, > if patches will be accepted: > >textdata bss dec hex filename > 17653 109968 240 127861 1f375 drivers/net/acenic.o >6628 120448 4

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 18:49, David Miller wrote: > From: Denys Vlasenko <[EMAIL PROTECTED]> > Date: Fri, 21 Sep 2007 18:03:55 +0100 > > > Do patches look ok to you? > > I'm travelling so I haven't looked closely yet :-) > > Michael can take a look and I'll try to do so as well > tonight.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko <[EMAIL PROTECTED]> Date: Fri, 21 Sep 2007 18:03:55 +0100 > Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. - To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 17:14, David Miller wrote: > From: Denys Vlasenko <[EMAIL PROTECTED]> > Date: Fri, 21 Sep 2007 12:01:24 +0100 > > > Hi Jeff, > > BNX2 and TG3 patches goes through Michael Chan and myself, > and I usually merge them in instead of Jeff. Didn't know that, sorry. Do

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko <[EMAIL PROTECTED]> Date: Fri, 21 Sep 2007 12:01:24 +0100 > Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
Hi Jeff, This patch modifies gzip unpacking code in bnx2 driver so that it does not depend on bnx2 internals. I will move this code out of the driver and into zlib in follow-on patch. It can be useful in other drivers which need to store firmwares or any other relatively big binary blobs -

[PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
Hi Jeff, This patch modifies gzip unpacking code in bnx2 driver so that it does not depend on bnx2 internals. I will move this code out of the driver and into zlib in follow-on patch. It can be useful in other drivers which need to store firmwares or any other relatively big binary blobs -

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 12:01:24 +0100 Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 17:14, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 12:01:24 +0100 Hi Jeff, BNX2 and TG3 patches goes through Michael Chan and myself, and I usually merge them in instead of Jeff. Didn't know that, sorry. Do patches look

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread David Miller
From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. - To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 18:49, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. Good. I

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375 drivers/net/acenic.o 6628 120448 4 127080

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Valdis . Kletnieks
On Fri, 21 Sep 2007 20:18:06 BST, Denys Vlasenko said: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: Should this be redone to use the existing firmware loading framework to load the firmware instead? Not in every case. For example, bnx2 maintainer says that driver and

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Andi Kleen
Denys Vlasenko [EMAIL PROTECTED] writes: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375 drivers/net/acenic.o 6628 120448 4 127080 1f068

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Krzysztof Oledzki
On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Roland Dreier
Just change the makefiles to always install gzip'ed modules modutils knows how to unzip them on the fly. But that leaves the uncompressed firmware blobs in .data that ends up in unswappable kernel memory. - R. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
For example, bnx2 maintainer says that driver and firmware are closely tied for his driver. IOW: you upgrade kernel and your NIC is not working anymore. Another argument is to make kernel be able to bring up NICs without needing firmware images in initramfs/initrd/hard drive. dgrs should

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Alan Cox wrote: For example, bnx2 maintainer says that driver and firmware are closely tied for his driver. IOW: you upgrade kernel and your NIC is not working anymore. Another argument is to make kernel be able to bring up NICs without needing firmware images in initramfs/initrd/hard drive.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 21:13, Andi Kleen wrote: Denys Vlasenko [EMAIL PROTECTED] writes: I plan to use gzip compression on following drivers' firmware, if patches will be accepted: textdata bss dec hex filename 17653 109968 240 127861 1f375

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Alan Cox
According to an earlier thread, dgrs was never really maintained, written for hardware that was never really distributed widely, and very likely hasn't had users in years... if ever. If that picture is accurate (it's a story I was told), then I am definitely queueing up a deletion patch.

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Denys Vlasenko
On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following drivers' firmware, if

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Jeff Garzik
Denys Vlasenko wrote: On Friday 21 September 2007 20:33, Krzysztof Oledzki wrote: On Fri, 21 Sep 2007, Denys Vlasenko wrote: On Friday 21 September 2007 19:36, [EMAIL PROTECTED] wrote: On Fri, 21 Sep 2007 19:05:23 BST, Denys Vlasenko said: I plan to use gzip compression on following

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread maximilian attems
On Fri, Sep 21, 2007 at 11:48:05PM +0100, Alan Cox wrote: According to an earlier thread, dgrs was never really maintained, written for hardware that was never really distributed widely, and very likely hasn't had users in years... if ever. If that picture is accurate (it's a story I

Re: [PATCH 1/2] bnx2: factor out gzip unpacker

2007-09-21 Thread Michael Chan
On Fri, 2007-09-21 at 10:49 -0700, David Miller wrote: From: Denys Vlasenko [EMAIL PROTECTED] Date: Fri, 21 Sep 2007 18:03:55 +0100 Do patches look ok to you? I'm travelling so I haven't looked closely yet :-) Michael can take a look and I'll try to do so as well tonight. I've