Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-05 Thread Andrzej Hajda
On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-05 Thread Andrzej Hajda
On 04.05.2017 14:35, Thierry Reding wrote: > On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: >> On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: >>> Laurent Pinchart writes: >>> Hi Daniel, On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > On Wed, May

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-04 Thread Thierry Reding
On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: > On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: > > Laurent Pinchart writes: > > > >> Hi Daniel, > >> > >> On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > >>> On Wed,

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-04 Thread Thierry Reding
On Thu, May 04, 2017 at 07:44:08AM +0200, Daniel Vetter wrote: > On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: > > Laurent Pinchart writes: > > > >> Hi Daniel, > >> > >> On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > >>> On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-04 Thread Archit Taneja
On 05/03/2017 10:00 PM, Eric Anholt wrote: Archit Taneja writes: Hi, On 04/27/2017 10:06 PM, Eric Anholt wrote: Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-04 Thread Archit Taneja
On 05/03/2017 10:00 PM, Eric Anholt wrote: Archit Taneja writes: Hi, On 04/27/2017 10:06 PM, Eric Anholt wrote: Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: > Laurent Pinchart writes: > >> Hi Daniel, >> >> On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: >>> On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: >>> > On Wednesday

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 3, 2017 at 6:17 PM, Eric Anholt wrote: > Laurent Pinchart writes: > >> Hi Daniel, >> >> On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: >>> On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: >>> > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: >>> >> On

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Eric Anholt
Archit Taneja writes: > Hi, > > On 04/27/2017 10:06 PM, Eric Anholt wrote: >> Many DRM drivers have common code to make a stub connector >> implementation that wraps a drm_panel. By wrapping the panel in a DRM >> bridge, all of the connector code (including calls during

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Eric Anholt
Archit Taneja writes: > Hi, > > On 04/27/2017 10:06 PM, Eric Anholt wrote: >> Many DRM drivers have common code to make a stub connector >> implementation that wraps a drm_panel. By wrapping the panel in a DRM >> bridge, all of the connector code (including calls during encoder >>

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Eric Anholt
Laurent Pinchart writes: > Hi Daniel, > > On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: >> On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: >> > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: >> >> On Wed, May 03, 2017 at

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Eric Anholt
Laurent Pinchart writes: > Hi Daniel, > > On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: >> On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: >> > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: >> >> On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote:

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Daniel, On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: > > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > >> On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > >>> +panel/bridge reviewers. > >>>

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Daniel, On Wednesday 03 May 2017 16:28:56 Daniel Vetter wrote: > On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: > > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > >> On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > >>> +panel/bridge reviewers. > >>>

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > > On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > > > +panel/bridge reviewers. > > > > > > This does make things much cleaner, but it seems

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 03, 2017 at 12:36:06PM +0300, Laurent Pinchart wrote: > Hi Daniel, > > On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > > On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > > > +panel/bridge reviewers. > > > > > > This does make things much cleaner, but it seems

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Thu, Apr 27, 2017 at 09:36:00AM -0700, Eric Anholt wrote: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > >

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Thu, Apr 27, 2017 at 09:36:00AM -0700, Eric Anholt wrote: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > >

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Daniel, On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > > +panel/bridge reviewers. > > > > This does make things much cleaner, but it seems a bit strange to create > > a drm_bridge when there isn't really a HW bridge in

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Daniel, On Wednesday 03 May 2017 11:32:17 Daniel Vetter wrote: > On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > > +panel/bridge reviewers. > > > > This does make things much cleaner, but it seems a bit strange to create > > a drm_bridge when there isn't really a HW bridge in

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > +panel/bridge reviewers. > > This does make things much cleaner, but it seems a bit strange to create > a drm_bridge when there isn't really a HW bridge in the display chain (i.e, > when the DSI encoder is directly connected to a

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Daniel Vetter
On Wed, May 03, 2017 at 02:53:00PM +0530, Archit Taneja wrote: > +panel/bridge reviewers. > > This does make things much cleaner, but it seems a bit strange to create > a drm_bridge when there isn't really a HW bridge in the display chain (i.e, > when the DSI encoder is directly connected to a

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Archit, On Wednesday 03 May 2017 14:53:00 Archit Taneja wrote: > On 04/27/2017 10:06 PM, Eric Anholt wrote: > > Many DRM drivers have common code to make a stub connector > > implementation that wraps a drm_panel. By wrapping the panel in a DRM > > bridge, all of the connector code (including

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Laurent Pinchart
Hi Archit, On Wednesday 03 May 2017 14:53:00 Archit Taneja wrote: > On 04/27/2017 10:06 PM, Eric Anholt wrote: > > Many DRM drivers have common code to make a stub connector > > implementation that wraps a drm_panel. By wrapping the panel in a DRM > > bridge, all of the connector code (including

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Archit Taneja
Hi, On 04/27/2017 10:06 PM, Eric Anholt wrote: Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-05-03 Thread Archit Taneja
Hi, On 04/27/2017 10:06 PM, Eric Anholt wrote: Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Eric Anholt writes: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > > Signed-off-by: Eric

Re: [PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Eric Anholt writes: > Many DRM drivers have common code to make a stub connector > implementation that wraps a drm_panel. By wrapping the panel in a DRM > bridge, all of the connector code (including calls during encoder > enable/disable) goes away. > > Signed-off-by: Eric Anholt > +/** > + *

[PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric Anholt ---

[PATCH 1/2] drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge.

2017-04-27 Thread Eric Anholt
Many DRM drivers have common code to make a stub connector implementation that wraps a drm_panel. By wrapping the panel in a DRM bridge, all of the connector code (including calls during encoder enable/disable) goes away. Signed-off-by: Eric Anholt --- Documentation/gpu/drm-kms-helpers.rst |