Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Linus Walleij
On Wed, Jul 11, 2012 at 11:13 AM, Tarun Kanti DebBarma wrote: > Since the bank->dbck initialization in a one time operation there > is no need to keep this within gpio_debounce(). Therefore, moving > clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of > bank->dbck would be NULL at

Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread DebBarma, Tarun Kanti
On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley wrote: > On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: > >> Since the bank->dbck initialization in a one time operation there >> is no need to keep this within gpio_debounce(). Therefore, moving >> clk_get(bank->dbck) to omap_gpio_mod_init().

Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Paul Walmsley
On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: > Since the bank->dbck initialization in a one time operation there > is no need to keep this within gpio_debounce(). Therefore, moving > clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of > bank->dbck would be NULL at the beginning,

[PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Tarun Kanti DebBarma
Since the bank->dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of bank->dbck would be NULL at the beginning, this check has been removed. Signed-off-by: Tarun Kanti

[PATCH 1/2] gpio/omap: move bank-dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Tarun Kanti DebBarma
Since the bank-dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank-dbck) to omap_gpio_mod_init(). Since the value of bank-dbck would be NULL at the beginning, this check has been removed. Signed-off-by: Tarun Kanti

Re: [PATCH 1/2] gpio/omap: move bank-dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Paul Walmsley
On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: Since the bank-dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank-dbck) to omap_gpio_mod_init(). Since the value of bank-dbck would be NULL at the beginning, this

Re: [PATCH 1/2] gpio/omap: move bank-dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread DebBarma, Tarun Kanti
On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: Since the bank-dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank-dbck) to omap_gpio_mod_init().

Re: [PATCH 1/2] gpio/omap: move bank-dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread Linus Walleij
On Wed, Jul 11, 2012 at 11:13 AM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Since the bank-dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank-dbck) to omap_gpio_mod_init(). Since the value of bank-dbck would be