Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/20/07, David Miller <[EMAIL PROTECTED]> wrote: Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually want a response from, and is bad netiquette in general.

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread David Miller
From: "rae l" <[EMAIL PROTECTED]> Date: Fri, 20 Jul 2007 09:51:05 +0800 > Is there any more comments on this? Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/18/07, Denis Cheng <[EMAIL PROTECTED]> wrote: - removed three function declarations from header file to mark them static, - reduced one file Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- this one is just merging by concatenating, and I'll try to adjust some function definitions'

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/18/07, Denis Cheng [EMAIL PROTECTED] wrote: - removed three function declarations from header file to mark them static, - reduced one file Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- this one is just merging by concatenating, and I'll try to adjust some function definitions' order to

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread David Miller
From: rae l [EMAIL PROTECTED] Date: Fri, 20 Jul 2007 09:51:05 +0800 Is there any more comments on this? Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually want a

Re: [PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-19 Thread rae l
On 7/20/07, David Miller [EMAIL PROTECTED] wrote: Please don't quote a big huge patch just to say one sentence that doesn't apply to any particular specific part of a patch. That's wastes bandwidth, annoys people you might actually want a response from, and is bad netiquette in general.

[PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-18 Thread Denis Cheng
- removed three function declarations from header file to mark them static, - reduced one file Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- this one is just merging by concatenating, and I'll try to adjust some function definitions' order to make it more readable.

[PATCH 1/2] net/core: merge the content of dev_mcast.c into dev.c

2007-07-18 Thread Denis Cheng
- removed three function declarations from header file to mark them static, - reduced one file Signed-off-by: Denis Cheng [EMAIL PROTECTED] --- this one is just merging by concatenating, and I'll try to adjust some function definitions' order to make it more readable. include/linux/netdevice.h