Paul,
On Wed, Mar 11, 2015 at 4:18 PM, Paul Bolle wrote:
> MODULE_DEVICE_TABLE() is defined only in include/linux/module.h. The few
> related lines read (in next-20150311):
> #ifdef MODULE
> /* Creates an alias so file2alias.c can find device table. */
> #define
Moritz,
On Wed, 2015-03-11 at 15:00 -0700, Moritz Fischer wrote:
> thanks for your feedback. While developing this I looked at other drivers in
> the tree and many of your comments would apply to them, too?
Could be. I didn't check. It's basically stuff that get's silently
handled by the
Paul,
thanks for your feedback. While developing this I looked at other drivers in
the tree and many of your comments would apply to them, too?
On Wed, Mar 11, 2015 at 2:31 AM, Paul Bolle > +config POWER_RESET_SYSCON_POWEROFF
>> + bool "Generic SYSCON regmap poweroff driver"
>
> This adds a
On Tue, 2015-03-10 at 16:21 -0700, Moritz Fischer wrote:
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> +config POWER_RESET_SYSCON_POWEROFF
> + bool "Generic SYSCON regmap poweroff driver"
This adds a bool symbol.
> + depends on OF
> + select MFD_SYSCON
>
Paul,
thanks for your feedback. While developing this I looked at other drivers in
the tree and many of your comments would apply to them, too?
On Wed, Mar 11, 2015 at 2:31 AM, Paul Bolle pebolle@tiscali
+config POWER_RESET_SYSCON_POWEROFF
+ bool Generic SYSCON regmap poweroff driver
Paul,
On Wed, Mar 11, 2015 at 4:18 PM, Paul Bolle pebo...@tiscali.nl wrote:
MODULE_DEVICE_TABLE() is defined only in include/linux/module.h. The few
related lines read (in next-20150311):
#ifdef MODULE
/* Creates an alias so file2alias.c can find device table. */
#define
Moritz,
On Wed, 2015-03-11 at 15:00 -0700, Moritz Fischer wrote:
thanks for your feedback. While developing this I looked at other drivers in
the tree and many of your comments would apply to them, too?
Could be. I didn't check. It's basically stuff that get's silently
handled by the
On Tue, 2015-03-10 at 16:21 -0700, Moritz Fischer wrote:
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
+config POWER_RESET_SYSCON_POWEROFF
+ bool Generic SYSCON regmap poweroff driver
This adds a bool symbol.
+ depends on OF
+ select MFD_SYSCON
+
Hi,
On Tue, Mar 10, 2015 at 04:21:09PM -0700, Moritz Fischer wrote:
> Add a generic SYSCON register mapped poweroff mechanism.
Driver looks mostly fine.
> [...]
> +#ifdef CONFIG_OF
> +static const struct of_device_id syscon_poweroff_of_match[] = {
> + { .compatible = "syscon-poweroff" },
>
Add a generic SYSCON register mapped poweroff mechanism.
Signed-off-by: Moritz Fischer
---
drivers/power/reset/Kconfig | 7 +++
drivers/power/reset/Makefile | 1 +
drivers/power/reset/syscon-poweroff.c | 97 +++
3 files changed, 105
Hi,
On Tue, Mar 10, 2015 at 04:21:09PM -0700, Moritz Fischer wrote:
Add a generic SYSCON register mapped poweroff mechanism.
Driver looks mostly fine.
[...]
+#ifdef CONFIG_OF
+static const struct of_device_id syscon_poweroff_of_match[] = {
+ { .compatible = syscon-poweroff },
+ {}
Add a generic SYSCON register mapped poweroff mechanism.
Signed-off-by: Moritz Fischer moritz.fisc...@ettus.com
---
drivers/power/reset/Kconfig | 7 +++
drivers/power/reset/Makefile | 1 +
drivers/power/reset/syscon-poweroff.c | 97 +++
3
12 matches
Mail list logo
