Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-09 Thread Feng Tang
Hi Petr and Sergey, On Wed, Apr 10, 2019 at 10:47:05AM +0900, Sergey Senozhatsky wrote: > On (04/09/19 15:41), Petr Mladek wrote: > > I suggest to merge the two patches into one. It will > > still be rather small and easier to review. > > Agreed, was going to suggest the same. Ok, will merge.

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-09 Thread Sergey Senozhatsky
On (04/09/19 15:41), Petr Mladek wrote: > I suggest to merge the two patches into one. It will > still be rather small and easier to review. Agreed, was going to suggest the same. -ss

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-09 Thread Petr Mladek
On Tue 2019-04-02 11:29:00, Sergey Senozhatsky wrote: > On (04/02/19 10:28), Feng Tang wrote: > > > So my first thought was - let's not add a `bool flag', but instead add > > > an `enum' with clear flag names, e.g. DUMP_ALL/DUMP_PENDING, etc. > > > Something > > > similar to what

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Feng Tang
Hi Mukesh, On Mon, Apr 01, 2019 at 05:20:33PM +0530, Mukesh Ojha wrote: > > On 4/1/2019 4:18 PM, Feng Tang wrote: > > Current console_flush_on_panic() will only dump the new messages > > in buffer, and users may need an opportunity to check all the > > messages on panic which could help

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Sergey Senozhatsky
On (04/02/19 10:28), Feng Tang wrote: > > So my first thought was - let's not add a `bool flag', but instead add > > an `enum' with clear flag names, e.g. DUMP_ALL/DUMP_PENDING, etc. Something > > similar to what ftrace_dump(DUMP_ALL) does. And we already have panic_print > > bit-mask and

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Feng Tang
Hi Sergey, Thanks for the review. On Tue, Apr 02, 2019 at 11:14:19AM +0900, Sergey Senozhatsky wrote: > On (04/01/19 18:48), Feng Tang wrote: > > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > > index 1fd45a8..58d9580 100644 > > --- a/arch/powerpc/kernel/traps.c > > +++

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Sergey Senozhatsky
On (04/01/19 18:48), Feng Tang wrote: > diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c > index 1fd45a8..58d9580 100644 > --- a/arch/powerpc/kernel/traps.c > +++ b/arch/powerpc/kernel/traps.c > @@ -179,7 +179,7 @@ extern void panic_flush_kmsg_end(void) >

Re: [PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Mukesh Ojha
On 4/1/2019 4:18 PM, Feng Tang wrote: Current console_flush_on_panic() will only dump the new messages in buffer, and users may need an opportunity to check all the messages on panic which could help debugging, as user may haven't seen the log before panic due to loglevel settings. Add a flag

[PATCH 1/2] printk: Add an option to flush all messages on panic

2019-04-01 Thread Feng Tang
Current console_flush_on_panic() will only dump the new messages in buffer, and users may need an opportunity to check all the messages on panic which could help debugging, as user may haven't seen the log before panic due to loglevel settings. Add a flag for console_flush_on_panic() to chose