Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-19 Thread Thierry Reding
On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > When first implementing support for changing the output frequency, an > optimization was added to continue the PWM after changing the prescaler > without having to reprogram the ON and OFF registers for the duty cycle, > in case the

Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-19 Thread Thierry Reding
On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > When first implementing support for changing the output frequency, an > optimization was added to continue the PWM after changing the prescaler > without having to reprogram the ON and OFF registers for the duty cycle, > in case the

Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-18 Thread Mika Westerberg
On Wed, Jan 18, 2017 at 11:56:50AM +0100, Thierry Reding wrote: > On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > > When first implementing support for changing the output frequency, an > > optimization was added to continue the PWM after changing the prescaler > > without having

Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-18 Thread Mika Westerberg
On Wed, Jan 18, 2017 at 11:56:50AM +0100, Thierry Reding wrote: > On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > > When first implementing support for changing the output frequency, an > > optimization was added to continue the PWM after changing the prescaler > > without having

Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-18 Thread Thierry Reding
On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > When first implementing support for changing the output frequency, an > optimization was added to continue the PWM after changing the prescaler > without having to reprogram the ON and OFF registers for the duty cycle, > in case the

Re: [PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2017-01-18 Thread Thierry Reding
On Tue, Dec 13, 2016 at 04:52:50PM +0100, Clemens Gruber wrote: > When first implementing support for changing the output frequency, an > optimization was added to continue the PWM after changing the prescaler > without having to reprogram the ON and OFF registers for the duty cycle, > in case the

[PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2016-12-13 Thread Clemens Gruber
When first implementing support for changing the output frequency, an optimization was added to continue the PWM after changing the prescaler without having to reprogram the ON and OFF registers for the duty cycle, in case the duty cycle stayed the same. This was flawed, because we compared the

[PATCH 1/2] pwm: pca9685: fix period change with same duty cycle

2016-12-13 Thread Clemens Gruber
When first implementing support for changing the output frequency, an optimization was added to continue the PWM after changing the prescaler without having to reprogram the ON and OFF registers for the duty cycle, in case the duty cycle stayed the same. This was flawed, because we compared the