Re: [PATCH 1/2] trace-cmd: use asprintf when possible

Hi Steven, On Mon, Jul 31, 2017 at 03:33:40PM -0400, Steven Rostedt wrote: On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga wrote: I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

Hi Steven, On Mon, Jul 31, 2017 at 03:33:40PM -0400, Steven Rostedt wrote: On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga wrote: I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) Ah you caught me in

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga wrote: > Hi Steven, > > I found some free time and unfortunately I can't enjoy the sun, so here I am > on this patch. > Before submitting the V2, one comment (inline) Ah you caught me in a middle of a very busy

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Tue, 25 Jul 2017 16:21:11 +0200 Federico Vaga wrote: > Hi Steven, > > I found some free time and unfortunately I can't enjoy the sun, so here I am > on this patch. > Before submitting the V2, one comment (inline) Ah you caught me in a middle of a very busy traveling week. > > But still,

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

Hi Steven, I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) On Monday, July 10, 2017 2:08:41 AM CEST Federico Vaga wrote: > On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > > On Mon, 5 Jun

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

Hi Steven, I found some free time and unfortunately I can't enjoy the sun, so here I am on this patch. Before submitting the V2, one comment (inline) On Monday, July 10, 2017 2:08:41 AM CEST Federico Vaga wrote: > On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > > On Mon, 5 Jun

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:17 +0200 > Federico Vaga wrote: > > Hi Federico, > > I finally got around to looking at these. Sorry for the really slow > reply, but I had a bunch of kernel work I needed to get

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Friday, July 7, 2017 12:25:32 AM CEST Steven Rostedt wrote: > On Mon, 5 Jun 2017 11:31:17 +0200 > Federico Vaga wrote: > > Hi Federico, > > I finally got around to looking at these. Sorry for the really slow > reply, but I had a bunch of kernel work I needed to get done before > digging

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Mon, 5 Jun 2017 11:31:17 +0200 Federico Vaga wrote: Hi Federico, I finally got around to looking at these. Sorry for the really slow reply, but I had a bunch of kernel work I needed to get done before digging again into trace-cmd. > It makes the code clearer and

Re: [PATCH 1/2] trace-cmd: use asprintf when possible

On Mon, 5 Jun 2017 11:31:17 +0200 Federico Vaga wrote: Hi Federico, I finally got around to looking at these. Sorry for the really slow reply, but I had a bunch of kernel work I needed to get done before digging again into trace-cmd. > It makes the code clearer and less error prone. > >

[PATCH 1/2] trace-cmd: use asprintf when possible

It makes the code clearer and less error prone. clearer: - less code - the code is now using the same format to create strings dynamically less error prone: - no magic number +2 +9 +5 to compute the size - no copy of the strings to compute the size and to concatenate The function `asprintf` is

[PATCH 1/2] trace-cmd: use asprintf when possible

It makes the code clearer and less error prone. clearer: - less code - the code is now using the same format to create strings dynamically less error prone: - no magic number +2 +9 +5 to compute the size - no copy of the strings to compute the size and to concatenate The function `asprintf` is