Re: [PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Andy Whitcroft
Dave Hansen wrote: > On Mon, 2007-03-12 at 18:23 +, Andy Whitcroft wrote: >> + /* The target page is in the block, ignore it. */ >> + if (unlikely(pfn == page_pfn)) >> + continue; >> +#ifdef CONFIG_HOLES_IN_ZONE >> +

Re: [PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Dave Hansen
On Mon, 2007-03-12 at 18:23 +, Andy Whitcroft wrote: > > + /* The target page is in the block, ignore it. */ > + if (unlikely(pfn == page_pfn)) > + continue; > +#ifdef CONFIG_HOLES_IN_ZONE > + /*

[PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Andy Whitcroft
When we are out of memory of a suitable size we enter reclaim. The current reclaim algorithm targets pages in LRU order, which is great for fairness at order-0 but highly unsuitable if you desire pages at higher orders. To get pages of higher order we must shoot down a very high proportion of

[PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Andy Whitcroft
When we are out of memory of a suitable size we enter reclaim. The current reclaim algorithm targets pages in LRU order, which is great for fairness at order-0 but highly unsuitable if you desire pages at higher orders. To get pages of higher order we must shoot down a very high proportion of

Re: [PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Dave Hansen
On Mon, 2007-03-12 at 18:23 +, Andy Whitcroft wrote: + /* The target page is in the block, ignore it. */ + if (unlikely(pfn == page_pfn)) + continue; +#ifdef CONFIG_HOLES_IN_ZONE + /* Avoid

Re: [PATCH 1/3] Lumpy Reclaim V4

2007-03-12 Thread Andy Whitcroft
Dave Hansen wrote: On Mon, 2007-03-12 at 18:23 +, Andy Whitcroft wrote: + /* The target page is in the block, ignore it. */ + if (unlikely(pfn == page_pfn)) + continue; +#ifdef CONFIG_HOLES_IN_ZONE +