Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi, On Wed, May 24, 2017 at 3:09 PM, Matthias Kaehlcke wrote: > Hi David, > > El Wed, May 24, 2017 at 01:36:21PM -0700 David Rientjes ha dit: > >> On Tue, 23 May 2017, Matthias Kaehlcke wrote: >> >> > > diff --git a/include/linux/compiler-clang.h >> > >

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi, On Wed, May 24, 2017 at 3:09 PM, Matthias Kaehlcke wrote: > Hi David, > > El Wed, May 24, 2017 at 01:36:21PM -0700 David Rientjes ha dit: > >> On Tue, 23 May 2017, Matthias Kaehlcke wrote: >> >> > > diff --git a/include/linux/compiler-clang.h >> > > b/include/linux/compiler-clang.h >> > >

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi David, El Wed, May 24, 2017 at 01:36:21PM -0700 David Rientjes ha dit: > On Tue, 23 May 2017, Matthias Kaehlcke wrote: > > > > diff --git a/include/linux/compiler-clang.h > > > b/include/linux/compiler-clang.h > > > index de179993e039..e1895ce6fa1b 100644 > > > ---

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi David, El Wed, May 24, 2017 at 01:36:21PM -0700 David Rientjes ha dit: > On Tue, 23 May 2017, Matthias Kaehlcke wrote: > > > > diff --git a/include/linux/compiler-clang.h > > > b/include/linux/compiler-clang.h > > > index de179993e039..e1895ce6fa1b 100644 > > > ---

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Tue, 23 May 2017, Matthias Kaehlcke wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index de179993e039..e1895ce6fa1b 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -15,3 +15,8 @@ > > * with any

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Tue, 23 May 2017, Matthias Kaehlcke wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > > index de179993e039..e1895ce6fa1b 100644 > > --- a/include/linux/compiler-clang.h > > +++ b/include/linux/compiler-clang.h > > @@ -15,3 +15,8 @@ > > * with any

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi, On Tue, May 23, 2017 at 9:56 AM, Matthias Kaehlcke wrote: > Hi David, > > El Mon, May 22, 2017 at 06:35:23PM -0700 David Rientjes ha dit: > >> On Mon, 22 May 2017, Andrew Morton wrote: >> >> > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I >> > >

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi, On Tue, May 23, 2017 at 9:56 AM, Matthias Kaehlcke wrote: > Hi David, > > El Mon, May 22, 2017 at 06:35:23PM -0700 David Rientjes ha dit: > >> On Mon, 22 May 2017, Andrew Morton wrote: >> >> > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I >> > > > don't >> > > >

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi David, El Mon, May 22, 2017 at 06:35:23PM -0700 David Rientjes ha dit: > On Mon, 22 May 2017, Andrew Morton wrote: > > > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I > > > > don't > > > > think this should ever warn on gcc. > > > > > > clang warns about unused

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

Hi David, El Mon, May 22, 2017 at 06:35:23PM -0700 David Rientjes ha dit: > On Mon, 22 May 2017, Andrew Morton wrote: > > > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I > > > > don't > > > > think this should ever warn on gcc. > > > > > > clang warns about unused

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Mon, 22 May 2017, Andrew Morton wrote: > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I don't > > > think this should ever warn on gcc. > > > > clang warns about unused static inline functions outside of header > > files, in difference to gcc. > > I wish it

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Mon, 22 May 2017, Andrew Morton wrote: > > > Is clang not inlining kmalloc_large_node_hook() for some reason? I don't > > > think this should ever warn on gcc. > > > > clang warns about unused static inline functions outside of header > > files, in difference to gcc. > > I wish it

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Mon, 22 May 2017 13:56:21 -0700 Matthias Kaehlcke wrote: > El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit: > > > On Fri, 19 May 2017, Matthias Kaehlcke wrote: > > > > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > > > block fixes

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Mon, 22 May 2017 13:56:21 -0700 Matthias Kaehlcke wrote: > El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit: > > > On Fri, 19 May 2017, Matthias Kaehlcke wrote: > > > > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > > > block fixes the following

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit: > On Fri, 19 May 2017, Matthias Kaehlcke wrote: > > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > > block fixes the following warning when building with clang: > > > > mm/slub.c:1246:20: error: unused

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

El Mon, May 22, 2017 at 01:39:26PM -0700 David Rientjes ha dit: > On Fri, 19 May 2017, Matthias Kaehlcke wrote: > > > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > > block fixes the following warning when building with clang: > > > > mm/slub.c:1246:20: error: unused

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Fri, 19 May 2017, Matthias Kaehlcke wrote: > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > block fixes the following warning when building with clang: > > mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' > [-Werror,-Wunused-function] > Is

Re: [PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

On Fri, 19 May 2017, Matthias Kaehlcke wrote: > The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef > block fixes the following warning when building with clang: > > mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' > [-Werror,-Wunused-function] > Is

[PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef block fixes the following warning when building with clang: mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke ---

[PATCH 1/3] mm/slub: Only define kmalloc_large_node_hook() for NUMA systems

The function is only used when CONFIG_NUMA=y. Placing it in an #ifdef block fixes the following warning when building with clang: mm/slub.c:1246:20: error: unused function 'kmalloc_large_node_hook' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- mm/slub.c | 3 +++ 1 file