Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-26 Thread Mark Brown
On Fri, Jan 25, 2013 at 10:20:29AM +0800, Axel Lin wrote: > The dev parameter is the device requesting the data. > In this case it should be >dev rather than pdev->dev.parent. Applied all, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-26 Thread Mark Brown
On Fri, Jan 25, 2013 at 10:20:29AM +0800, Axel Lin wrote: The dev parameter is the device requesting the data. In this case it should be pdev-dev rather than pdev-dev.parent. Applied all, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-24 Thread Stephen Warren
On 01/24/2013 06:20 PM, Axel Lin wrote: > The dev parameter is the device requesting the data. > In this case it should be >dev rather than pdev->dev.parent. > > The dev parameter is used to call devm_kzalloc in > of_get_regulator_init_data(), > which means this fixes a memory leak because the

[PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-24 Thread Axel Lin
The dev parameter is the device requesting the data. In this case it should be >dev rather than pdev->dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus

[PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-24 Thread Axel Lin
The dev parameter is the device requesting the data. In this case it should be pdev-dev rather than pdev-dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called,

Re: [PATCH 1/3] regulator: max8907: Fix using wrong dev argument for calling of_regulator_match

2013-01-24 Thread Stephen Warren
On 01/24/2013 06:20 PM, Axel Lin wrote: The dev parameter is the device requesting the data. In this case it should be pdev-dev rather than pdev-dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the