Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-22 Thread Bjorn Andersson
On Tue 22 Aug 17:28 PDT 2017, Chris Lew wrote: > On 8/21/2017 10:17 AM, Bjorn Andersson wrote: [..] > > > +static int qcom_smem_set_global_partition(struct qcom_smem *smem, > > > + struct smem_ptable_entry *entry) > > > +{ [..] > > > + if (header->size != entry->size) { > >

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-22 Thread Bjorn Andersson
On Tue 22 Aug 17:28 PDT 2017, Chris Lew wrote: > On 8/21/2017 10:17 AM, Bjorn Andersson wrote: [..] > > > +static int qcom_smem_set_global_partition(struct qcom_smem *smem, > > > + struct smem_ptable_entry *entry) > > > +{ [..] > > > + if (header->size != entry->size) { > >

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-22 Thread Chris Lew
Hi Bjorn, Thanks for the review. On 8/21/2017 10:17 AM, Bjorn Andersson wrote: #define SMEM_MASTER_SBL_VERSION_INDEX7 -#define SMEM_EXPECTED_VERSION 11 +#define SMEM_GLOBAL_HEAP_VERSION 11 + +/* + * Version 12 (SMEM_GLOBAL_PART_VERSION) changes the item alloc/get

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-22 Thread Chris Lew
Hi Bjorn, Thanks for the review. On 8/21/2017 10:17 AM, Bjorn Andersson wrote: #define SMEM_MASTER_SBL_VERSION_INDEX7 -#define SMEM_EXPECTED_VERSION 11 +#define SMEM_GLOBAL_HEAP_VERSION 11 + +/* + * Version 12 (SMEM_GLOBAL_PART_VERSION) changes the item alloc/get

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-21 Thread Bjorn Andersson
On Thu 17 Aug 18:15 PDT 2017, Chris Lew wrote: > SMEM V12 creates a global partition to allocate global > smem items from instead of a global heap. The global > partition has the same structure as a private partition. > Welcome to LKML! This looks quite reasonable, just some minor comments

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-21 Thread Bjorn Andersson
On Thu 17 Aug 18:15 PDT 2017, Chris Lew wrote: > SMEM V12 creates a global partition to allocate global > smem items from instead of a global heap. The global > partition has the same structure as a private partition. > Welcome to LKML! This looks quite reasonable, just some minor comments

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-21 Thread Arun Kumar Neelakantam
On 8/18/2017 6:45 AM, Chris Lew wrote: @@ -782,7 +855,10 @@ static int qcom_smem_probe(struct platform_device *pdev) } version = qcom_smem_get_sbl_version(smem); - if (version >> 16 != SMEM_EXPECTED_VERSION) { + switch (version >> 16) { + case

Re: [PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-21 Thread Arun Kumar Neelakantam
On 8/18/2017 6:45 AM, Chris Lew wrote: @@ -782,7 +855,10 @@ static int qcom_smem_probe(struct platform_device *pdev) } version = qcom_smem_get_sbl_version(smem); - if (version >> 16 != SMEM_EXPECTED_VERSION) { + switch (version >> 16) { + case

[PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-17 Thread Chris Lew
SMEM V12 creates a global partition to allocate global smem items from instead of a global heap. The global partition has the same structure as a private partition. Signed-off-by: Chris Lew --- drivers/soc/qcom/smem.c | 134 +---

[PATCH 1/3] soc: qcom: smem: Support global partition

2017-08-17 Thread Chris Lew
SMEM V12 creates a global partition to allocate global smem items from instead of a global heap. The global partition has the same structure as a private partition. Signed-off-by: Chris Lew --- drivers/soc/qcom/smem.c | 134 +--- 1 file changed, 105