Re: [PATCH 1/3] vfs: Do not ignore return code from s_op->sync_fs

2020-12-22 Thread Vivek Goyal
On Tue, Dec 22, 2020 at 12:23:11PM +1100, NeilBrown wrote: [...] > > diff --git a/fs/sync.c b/fs/sync.c > > index 1373a610dc78..b5fb83a734cd 100644 > > --- a/fs/sync.c > > +++ b/fs/sync.c > > @@ -30,14 +30,18 @@ > > */ > > static int __sync_filesystem(struct super_block *sb, int wait) > > { >

Re: [PATCH 1/3] vfs: Do not ignore return code from s_op->sync_fs

2020-12-21 Thread NeilBrown
On Mon, Dec 21 2020, Vivek Goyal wrote: > Current implementation of __sync_filesystem() ignores the > return code from ->sync_fs(). I am not sure why that's the case. > > Ignoring ->sync_fs() return code is problematic for overlayfs where > it can return error if sync_filesystem() on upper super

[PATCH 1/3] vfs: Do not ignore return code from s_op->sync_fs

2020-12-21 Thread Vivek Goyal
Current implementation of __sync_filesystem() ignores the return code from ->sync_fs(). I am not sure why that's the case. Ignoring ->sync_fs() return code is problematic for overlayfs where it can return error if sync_filesystem() on upper super block failed. That error will simply be lost and