Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-10 Thread Anshuman Khandual
On 10/10/2018 03:09 PM, Michal Hocko wrote: > On Wed 10-10-18 08:39:22, Anshuman Khandual wrote: > [...] >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 9df1d59..4bcbf1e 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -504,6 +504,16 @@

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-10 Thread Anshuman Khandual
On 10/10/2018 03:09 PM, Michal Hocko wrote: > On Wed 10-10-18 08:39:22, Anshuman Khandual wrote: > [...] >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 9df1d59..4bcbf1e 100644 >> --- a/include/linux/hugetlb.h >> +++ b/include/linux/hugetlb.h >> @@ -504,6 +504,16 @@

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-10 Thread Michal Hocko
On Wed 10-10-18 08:39:22, Anshuman Khandual wrote: [...] > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 9df1d59..4bcbf1e 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -504,6 +504,16 @@ static inline bool hugepage_migration_supported(struct >

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-10 Thread Michal Hocko
On Wed 10-10-18 08:39:22, Anshuman Khandual wrote: [...] > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 9df1d59..4bcbf1e 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -504,6 +504,16 @@ static inline bool hugepage_migration_supported(struct >

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-09 Thread Anshuman Khandual
On 10/09/2018 07:44 PM, Michal Hocko wrote: > On Fri 05-10-18 13:04:43, Anshuman Khandual wrote: >> Does the following sound close enough to what you are looking for ? > > I do not think so Okay. > >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 9df1d59..070c419

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-09 Thread Anshuman Khandual
On 10/09/2018 07:44 PM, Michal Hocko wrote: > On Fri 05-10-18 13:04:43, Anshuman Khandual wrote: >> Does the following sound close enough to what you are looking for ? > > I do not think so Okay. > >> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h >> index 9df1d59..070c419

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:04:43, Anshuman Khandual wrote: > Does the following sound close enough to what you are looking for ? I do not think so > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 9df1d59..070c419 100644 > --- a/include/linux/hugetlb.h > +++

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-09 Thread Michal Hocko
On Fri 05-10-18 13:04:43, Anshuman Khandual wrote: > Does the following sound close enough to what you are looking for ? I do not think so > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 9df1d59..070c419 100644 > --- a/include/linux/hugetlb.h > +++

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-05 Thread Anshuman Khandual
On 10/03/2018 07:06 PM, Michal Hocko wrote: > On Wed 03-10-18 18:36:39, Anshuman Khandual wrote: > [...] >> So we have two checks here >> >> 1) platform specific arch_hugetlb_migration -> In principle go ahead >> >> 2) huge_movable() during allocation >> >> - If huge page does not have to

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-05 Thread Anshuman Khandual
On 10/03/2018 07:06 PM, Michal Hocko wrote: > On Wed 03-10-18 18:36:39, Anshuman Khandual wrote: > [...] >> So we have two checks here >> >> 1) platform specific arch_hugetlb_migration -> In principle go ahead >> >> 2) huge_movable() during allocation >> >> - If huge page does not have to

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 18:36:39, Anshuman Khandual wrote: [...] > So we have two checks here > > 1) platform specific arch_hugetlb_migration -> In principle go ahead > > 2) huge_movable() during allocation > > - If huge page does not have to be placed on movable zone > > -

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 18:36:39, Anshuman Khandual wrote: [...] > So we have two checks here > > 1) platform specific arch_hugetlb_migration -> In principle go ahead > > 2) huge_movable() during allocation > > - If huge page does not have to be placed on movable zone > > -

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 05:18 PM, Michal Hocko wrote: > On Wed 03-10-18 17:07:13, Anshuman Khandual wrote: >> >> >> On 10/03/2018 04:29 PM, Michal Hocko wrote: > [...] >>> It is not the platform that decides. That is the whole point of the >>> distinction. It is us to say what is feasible and what we

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 05:18 PM, Michal Hocko wrote: > On Wed 03-10-18 17:07:13, Anshuman Khandual wrote: >> >> >> On 10/03/2018 04:29 PM, Michal Hocko wrote: > [...] >>> It is not the platform that decides. That is the whole point of the >>> distinction. It is us to say what is feasible and what we

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 17:07:13, Anshuman Khandual wrote: > > > On 10/03/2018 04:29 PM, Michal Hocko wrote: [...] > > It is not the platform that decides. That is the whole point of the > > distinction. It is us to say what is feasible and what we want to > > support. Do we want to support giga pages

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 17:07:13, Anshuman Khandual wrote: > > > On 10/03/2018 04:29 PM, Michal Hocko wrote: [...] > > It is not the platform that decides. That is the whole point of the > > distinction. It is us to say what is feasible and what we want to > > support. Do we want to support giga pages

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 04:29 PM, Michal Hocko wrote: > On Wed 03-10-18 15:28:23, Anshuman Khandual wrote: >> >> >> On 10/03/2018 12:28 PM, Michal Hocko wrote: >>> On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: On 10/02/2018 06:09 PM, Michal Hocko wrote: > On Tue 02-10-18 17:45:28,

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 04:29 PM, Michal Hocko wrote: > On Wed 03-10-18 15:28:23, Anshuman Khandual wrote: >> >> >> On 10/03/2018 12:28 PM, Michal Hocko wrote: >>> On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: On 10/02/2018 06:09 PM, Michal Hocko wrote: > On Tue 02-10-18 17:45:28,

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote: [...] > I have been under the idea that all the checks at the same level could > have the same indentation. (i.e, 2 tabs in this case for each). Looks > like there is no rule about it. How about replacing it with a > switch..case ? I would simply

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 12:17:52, Suzuki K Poulose wrote: [...] > I have been under the idea that all the checks at the same level could > have the same indentation. (i.e, 2 tabs in this case for each). Looks > like there is no rule about it. How about replacing it with a > switch..case ? I would simply

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Suzuki K Poulose
On 03/10/18 12:10, Anshuman Khandual wrote: On 10/03/2018 03:52 PM, Suzuki K Poulose wrote: On 02/10/18 13:56, Anshuman Khandual wrote: On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Suzuki K Poulose
On 03/10/18 12:10, Anshuman Khandual wrote: On 10/03/2018 03:52 PM, Suzuki K Poulose wrote: On 02/10/18 13:56, Anshuman Khandual wrote: On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 03:52 PM, Suzuki K Poulose wrote: > > > On 02/10/18 13:56, Anshuman Khandual wrote: >> >> >> On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: >>> Hi Anshuman >>> >>> On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 03:52 PM, Suzuki K Poulose wrote: > > > On 02/10/18 13:56, Anshuman Khandual wrote: >> >> >> On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: >>> Hi Anshuman >>> >>> On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 15:28:23, Anshuman Khandual wrote: > > > On 10/03/2018 12:28 PM, Michal Hocko wrote: > > On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: > >> > >> > >> On 10/02/2018 06:09 PM, Michal Hocko wrote: > >>> On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > Architectures

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 15:28:23, Anshuman Khandual wrote: > > > On 10/03/2018 12:28 PM, Michal Hocko wrote: > > On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: > >> > >> > >> On 10/02/2018 06:09 PM, Michal Hocko wrote: > >>> On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > Architectures

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Suzuki K Poulose
On 02/10/18 13:56, Anshuman Khandual wrote: On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Suzuki K Poulose
On 02/10/18 13:56, Anshuman Khandual wrote: On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 12:28 PM, Michal Hocko wrote: > On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: >> >> >> On 10/02/2018 06:09 PM, Michal Hocko wrote: >>> On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Anshuman Khandual
On 10/03/2018 12:28 PM, Michal Hocko wrote: > On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: >> >> >> On 10/02/2018 06:09 PM, Michal Hocko wrote: >>> On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: > > > On 10/02/2018 06:09 PM, Michal Hocko wrote: > > On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > >> Architectures like arm64 have PUD level HugeTLB pages for certain configs > >> (1GB huge page is PUD based on ARM64_4K_PAGES base page

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-03 Thread Michal Hocko
On Wed 03-10-18 07:46:27, Anshuman Khandual wrote: > > > On 10/02/2018 06:09 PM, Michal Hocko wrote: > > On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > >> Architectures like arm64 have PUD level HugeTLB pages for certain configs > >> (1GB huge page is PUD based on ARM64_4K_PAGES base page

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
On 10/02/2018 06:09 PM, Michal Hocko wrote: > On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: >> Architectures like arm64 have PUD level HugeTLB pages for certain configs >> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be >> enabled for migration. It can be achieved

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
On 10/02/2018 06:09 PM, Michal Hocko wrote: > On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: >> Architectures like arm64 have PUD level HugeTLB pages for certain configs >> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be >> enabled for migration. It can be achieved

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: > Hi Anshuman > > On 02/10/18 13:15, Anshuman Khandual wrote: >> Architectures like arm64 have PUD level HugeTLB pages for certain configs >> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be >> enabled for migration. It

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
On 10/02/2018 06:08 PM, Suzuki K Poulose wrote: > Hi Anshuman > > On 02/10/18 13:15, Anshuman Khandual wrote: >> Architectures like arm64 have PUD level HugeTLB pages for certain configs >> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be >> enabled for migration. It

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Michal Hocko
On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > Architectures like arm64 have PUD level HugeTLB pages for certain configs > (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be > enabled for migration. It can be achieved through checking for PUD_SHIFT > order based

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Michal Hocko
On Tue 02-10-18 17:45:28, Anshuman Khandual wrote: > Architectures like arm64 have PUD level HugeTLB pages for certain configs > (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be > enabled for migration. It can be achieved through checking for PUD_SHIFT > order based

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Suzuki K Poulose
Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be enabled for migration. It can be achieved through checking for PUD_SHIFT order based

Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Suzuki K Poulose
Hi Anshuman On 02/10/18 13:15, Anshuman Khandual wrote: Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be enabled for migration. It can be achieved through checking for PUD_SHIFT order based

[PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be enabled for migration. It can be achieved through checking for PUD_SHIFT order based HugeTLB pages during migration. Signed-off-by: Anshuman Khandual

[PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration

2018-10-02 Thread Anshuman Khandual
Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be enabled for migration. It can be achieved through checking for PUD_SHIFT order based HugeTLB pages during migration. Signed-off-by: Anshuman Khandual