Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-30 Thread Liang, Kan
On 4/30/2019 4:56 AM, Peter Zijlstra wrote: On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index e47ef76..039e2f2 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h @@

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-30 Thread Peter Zijlstra
On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index e47ef76..039e2f2 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -795,6 +795,7 @@ struct perf_cpu_context { >

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread Liang, Kan
On 4/29/2019 11:04 AM, Mark Rutland wrote: On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: From: Kan Liang When counting system-wide events and cgroup events simultaneously, the value of system-wide events are miscounting. For example, perf stat -e

Re: [PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread Mark Rutland
On Mon, Apr 29, 2019 at 07:44:02AM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > When counting system-wide events and cgroup events simultaneously, the > value of system-wide events are miscounting. For example, > > perf stat -e cycles,instructions -e cycles,instructions -G

[PATCH 1/4] perf: Fix system-wide events miscounting during cgroup monitoring

2019-04-29 Thread kan . liang
From: Kan Liang When counting system-wide events and cgroup events simultaneously, the value of system-wide events are miscounting. For example, perf stat -e cycles,instructions -e cycles,instructions -G cgroup1,cgroup1,cgroup2,cgroup2 -a -e cycles,instructions -I 1000 1.096265502