Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/29/2013 01:30 PM, Thierry Reding wrote: >> Right. Now I know the background. >> However I do not agree with the conclusion. Probably it is fine in some cases >> to limit the number of configurable duty cycles to have only distinct steps. >> To not go too far, on my laptop I have: >> # cat

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Thierry Reding
On Tue, Jan 29, 2013 at 01:10:19PM +0100, Peter Ujfalusi wrote: > On 01/29/2013 11:17 AM, Thierry Reding wrote: > > On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: > >> On 01/28/2013 10:01 PM, Thierry Reding wrote: > >>> On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/29/2013 11:17 AM, Thierry Reding wrote: > On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: >> On 01/28/2013 10:01 PM, Thierry Reding wrote: >>> On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is expected that board files would have: static unsigned

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Thierry Reding
On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: > On 01/28/2013 10:01 PM, Thierry Reding wrote: > > On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: > >> It is expected that board files would have: > >> static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250,

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/28/2013 10:01 PM, Thierry Reding wrote: > On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: >> It is expected that board files would have: >> static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; >> >> static struct platform_pwm_backlight_data bl_data = { >>

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Thierry Reding
On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: On 01/28/2013 10:01 PM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is expected that board files would have: static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, };

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/29/2013 11:17 AM, Thierry Reding wrote: On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: On 01/28/2013 10:01 PM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is expected that board files would have: static unsigned int

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Thierry Reding
On Tue, Jan 29, 2013 at 01:10:19PM +0100, Peter Ujfalusi wrote: On 01/29/2013 11:17 AM, Thierry Reding wrote: On Tue, Jan 29, 2013 at 09:17:04AM +0100, Peter Ujfalusi wrote: On 01/28/2013 10:01 PM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/29/2013 01:30 PM, Thierry Reding wrote: Right. Now I know the background. However I do not agree with the conclusion. Probably it is fine in some cases to limit the number of configurable duty cycles to have only distinct steps. To not go too far, on my laptop I have: # cat

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-29 Thread Peter Ujfalusi
On 01/28/2013 10:01 PM, Thierry Reding wrote: On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is expected that board files would have: static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; static struct platform_pwm_backlight_data bl_data = { .levels =

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-28 Thread Thierry Reding
On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: > It is expected that board files would have: > static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; > > static struct platform_pwm_backlight_data bl_data = { > .levels = bl_levels, > .max_brightness =

Re: [PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-28 Thread Thierry Reding
On Tue, Jan 22, 2013 at 02:39:53PM +0100, Peter Ujfalusi wrote: It is expected that board files would have: static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; static struct platform_pwm_backlight_data bl_data = { .levels = bl_levels, .max_brightness =

[PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-22 Thread Peter Ujfalusi
It is expected that board files would have: static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; static struct platform_pwm_backlight_data bl_data = { .levels = bl_levels, .max_brightness = ARRAY_SIZE(bl_levels), .dft_brightness = 4, .pwm_period_ns =

[PATCH 1/4] pwm_backlight: Fix PWM levels support in non DT case

2013-01-22 Thread Peter Ujfalusi
It is expected that board files would have: static unsigned int bl_levels[] = { 0, 50, 100, 150, 200, 250, }; static struct platform_pwm_backlight_data bl_data = { .levels = bl_levels, .max_brightness = ARRAY_SIZE(bl_levels), .dft_brightness = 4, .pwm_period_ns =