Re: [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-12-04 Thread David Howells
Dmitry Kasatkin wrote: > > + struct asymmetric_key_id *auth_id; /* CA AuthKeyId matching ->id > > (optional) */ > > + struct asymmetric_key_id *auth_skid;/* CA AuthKeyId matching ->skid > > (optional) */ > > Hi David, > > Why do you call it "auth_skid", not just akid in similar

Re: [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-12-04 Thread Dmitry Kasatkin
On 26/11/14 16:17, David Howells wrote: > Extract both parts of the AuthorityKeyIdentifier, not just the keyIdentifier, > as the second part can be used to match X.509 certificates by issuer and > serialNumber. > > Signed-off-by: David Howells > --- > > crypto/asymmetric_keys/Makefile

Re: [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-12-04 Thread Dmitry Kasatkin
On 26/11/14 16:17, David Howells wrote: Extract both parts of the AuthorityKeyIdentifier, not just the keyIdentifier, as the second part can be used to match X.509 certificates by issuer and serialNumber. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/Makefile

Re: [PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-12-04 Thread David Howells
Dmitry Kasatkin d.kasat...@samsung.com wrote: + struct asymmetric_key_id *auth_id; /* CA AuthKeyId matching -id (optional) */ + struct asymmetric_key_id *auth_skid;/* CA AuthKeyId matching -skid (optional) */ Hi David, Why do you call it auth_skid, not just akid in

[PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-11-26 Thread David Howells
Extract both parts of the AuthorityKeyIdentifier, not just the keyIdentifier, as the second part can be used to match X.509 certificates by issuer and serialNumber. Signed-off-by: David Howells --- crypto/asymmetric_keys/Makefile |8 +- crypto/asymmetric_keys/pkcs7_trust.c |

[PATCH 1/5] X.509: Extract both parts of the AuthorityKeyIdentifier [ver #2]

2014-11-26 Thread David Howells
Extract both parts of the AuthorityKeyIdentifier, not just the keyIdentifier, as the second part can be used to match X.509 certificates by issuer and serialNumber. Signed-off-by: David Howells dhowe...@redhat.com --- crypto/asymmetric_keys/Makefile |8 +-