Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-09 Thread Frank Haverkamp
Hi, Am Freitag, den 06.12.2013, 09:39 +0100 schrieb Frank Haverkamp: > Hi Arnd, > > Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann: > > On Thursday 05 December 2013, Frank Haverkamp wrote: > > > > > Was wrong, as already pointed out before. It is now: > > > > > > > > > >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-09 Thread Frank Haverkamp
Hi, Am Freitag, den 06.12.2013, 09:39 +0100 schrieb Frank Haverkamp: Hi Arnd, Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann: On Thursday 05 December 2013, Frank Haverkamp wrote: Was wrong, as already pointed out before. It is now: struct genwqe_mem {

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-06 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann: > On Thursday 05 December 2013, Frank Haverkamp wrote: > > > > Was wrong, as already pointed out before. It is now: > > > > > > > > struct genwqe_mem { > > > > __u64 addr; > > > > __u64 size; > > > > int

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-06 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 21:31 +0100 schrieb Arnd Bergmann: On Thursday 05 December 2013, Frank Haverkamp wrote: Was wrong, as already pointed out before. It is now: struct genwqe_mem { __u64 addr; __u64 size; int direction; }; I

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Arnd Bergmann
On Thursday 05 December 2013, Frank Haverkamp wrote: > > > Was wrong, as already pointed out before. It is now: > > > > > > struct genwqe_mem { > > > __u64 addr; > > > __u64 size; > > > int direction; > > > }; > > > > > > I hope the int is ok here. > > > > No, it's not. The problem

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 03:38 +0100 schrieb Arnd Bergmann: > On Wednesday 04 December 2013, Frank Haverkamp wrote: > > Hi Arnd & Greg, > > > > please let me know if my following changes are ok: > > > > Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > > > > >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 03:27 +0100 schrieb Arnd Bergmann: > On Wednesday 04 December 2013, Frank Haverkamp wrote: > > Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > > > + */ > > > +struct genwqe_mem { > > > + unsigned long addr; > > > + unsigned

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 03:27 +0100 schrieb Arnd Bergmann: On Wednesday 04 December 2013, Frank Haverkamp wrote: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: + */ +struct genwqe_mem { + unsigned long addr; + unsigned long size; +

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Frank Haverkamp
Hi Arnd, Am Donnerstag, den 05.12.2013, 03:38 +0100 schrieb Arnd Bergmann: On Wednesday 04 December 2013, Frank Haverkamp wrote: Hi Arnd Greg, please let me know if my following changes are ok: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: +/* Read/write

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-05 Thread Arnd Bergmann
On Thursday 05 December 2013, Frank Haverkamp wrote: Was wrong, as already pointed out before. It is now: struct genwqe_mem { __u64 addr; __u64 size; int direction; }; I hope the int is ok here. No, it's not. The problem is that sizeof(struct

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Arnd Bergmann
On Wednesday 04 December 2013, Frank Haverkamp wrote: > Hi Arnd & Greg, > > please let me know if my following changes are ok: > > Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > > > +/* Read/write from/to registers */ > > +struct genwqe_regs_io { > > + __u32 num;

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Arnd Bergmann
On Wednesday 04 December 2013, Frank Haverkamp wrote: > Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > > + */ > > +struct genwqe_mem { > > + unsigned long addr; > > + unsigned long size; > > + int direction; > > +}; > > + > > +#define GENWQE_PIN_MEM

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi Arnd & Greg, please let me know if my following changes are ok: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > +/* Read/write from/to registers */ > +struct genwqe_regs_io { > + __u32 num; /* register offset/address */ > + union { > +

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi, Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: > + */ > +struct genwqe_mem { > + unsigned long addr; > + unsigned long size; > + int direction; > +}; > + > +#define GENWQE_PIN_MEM _IOWR(GENWQE_IOC_CODE, 40, struct > genwqe_mem *) > +#define

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi Arnd, thanks for helping to review the code. Am Dienstag, den 03.12.2013, 16:05 +0100 schrieb Arnd Bergmann: > On Tuesday 03 December 2013, Frank Haverkamp wrote: > > Ohh, sorry __u64 of course: > > > > /* common struct for chip image exchange */ > > struct genwqe_bitstream { > >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi Arnd, thanks for helping to review the code. Am Dienstag, den 03.12.2013, 16:05 +0100 schrieb Arnd Bergmann: On Tuesday 03 December 2013, Frank Haverkamp wrote: Ohh, sorry __u64 of course: /* common struct for chip image exchange */ struct genwqe_bitstream { __u64

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi, Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: + */ +struct genwqe_mem { + unsigned long addr; + unsigned long size; + int direction; +}; + +#define GENWQE_PIN_MEM _IOWR(GENWQE_IOC_CODE, 40, struct genwqe_mem *) +#define GENWQE_UNPIN_MEM

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Frank Haverkamp
Hi Arnd Greg, please let me know if my following changes are ok: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: +/* Read/write from/to registers */ +struct genwqe_regs_io { + __u32 num; /* register offset/address */ + union { +

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Arnd Bergmann
On Wednesday 04 December 2013, Frank Haverkamp wrote: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: + */ +struct genwqe_mem { + unsigned long addr; + unsigned long size; + int direction; +}; + +#define GENWQE_PIN_MEM

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-04 Thread Arnd Bergmann
On Wednesday 04 December 2013, Frank Haverkamp wrote: Hi Arnd Greg, please let me know if my following changes are ok: Am Dienstag, den 03.12.2013, 15:28 +0100 schrieb Frank Haverkamp: +/* Read/write from/to registers */ +struct genwqe_regs_io { + __u32 num; /*

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Arnd Bergmann
On Tuesday 03 December 2013, Frank Haverkamp wrote: > Ohh, sorry __u64 of course: > > /* common struct for chip image exchange */ > struct genwqe_bitstream { > __u64 data_addr;/* pointer to image data */ > __u32 size; /* size of image file */ >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Am Dienstag, den 03.12.2013, 06:30 -0800 schrieb Greg KH: > On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote: > > > > +/* common struct for chip image exchange */ > > > > +struct chip_bitstream { > > > > + uint8_t __user *pdata; /* pointer to image data */ > > > >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote: > > > +/* common struct for chip image exchange */ > > > +struct chip_bitstream { > > > + uint8_t __user *pdata; /* pointer to image data */ > > > + int size; /* size of image file*/ > > >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 02:49:41PM +0100, Frank Haverkamp wrote: > Hi Greg, > > Am Mittwoch, den 27.11.2013, 11:20 -0800 schrieb Greg KH: > > On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > > > +/* > > > + * Flags for extended output (dbg_print) > > > + * We define different

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 27.11.2013, 11:20 -0800 schrieb Greg KH: > On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > > +/* > > + * Flags for extended output (dbg_print) > > + * We define different levels of debugging for the appropriate unit. > > + */ > > +#define dbg_card

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 27.11.2013, 11:16 -0800 schrieb Greg KH: > On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > > --- /dev/null > > +++ b/include/linux/genwqe/genwqe_card.h > > @@ -0,0 +1,547 @@ > > +#ifndef __GENWQE_CARD_H__ > > +#define __GENWQE_CARD_H__ > > + > > +/** >

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 27.11.2013, 11:16 -0800 schrieb Greg KH: On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: --- /dev/null +++ b/include/linux/genwqe/genwqe_card.h @@ -0,0 +1,547 @@ +#ifndef __GENWQE_CARD_H__ +#define __GENWQE_CARD_H__ + +/** + * IBM

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Hi Greg, Am Mittwoch, den 27.11.2013, 11:20 -0800 schrieb Greg KH: On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: +/* + * Flags for extended output (dbg_print) + * We define different levels of debugging for the appropriate unit. + */ +#define dbg_card

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 02:49:41PM +0100, Frank Haverkamp wrote: Hi Greg, Am Mittwoch, den 27.11.2013, 11:20 -0800 schrieb Greg KH: On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: +/* + * Flags for extended output (dbg_print) + * We define different levels of

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Greg KH
On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote: +/* common struct for chip image exchange */ +struct chip_bitstream { + uint8_t __user *pdata; /* pointer to image data */ + int size; /* size of image file*/ I think this

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Frank Haverkamp
Am Dienstag, den 03.12.2013, 06:30 -0800 schrieb Greg KH: On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote: +/* common struct for chip image exchange */ +struct chip_bitstream { + uint8_t __user *pdata; /* pointer to image data */ + int

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-12-03 Thread Arnd Bergmann
On Tuesday 03 December 2013, Frank Haverkamp wrote: Ohh, sorry __u64 of course: /* common struct for chip image exchange */ struct genwqe_bitstream { __u64 data_addr;/* pointer to image data */ __u32 size; /* size of image file */

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-11-27 Thread Greg KH
On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > +/* > + * Flags for extended output (dbg_print) > + * We define different levels of debugging for the appropriate unit. > + */ > +#define dbg_card 0x0001 > +#define dbg_card_ddcb

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-11-27 Thread Greg KH
On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: > --- /dev/null > +++ b/include/linux/genwqe/genwqe_card.h > @@ -0,0 +1,547 @@ > +#ifndef __GENWQE_CARD_H__ > +#define __GENWQE_CARD_H__ > + > +/** > + * IBM Accelerator Family 'GenWQE' > + * > + * (C) Copyright IBM Corp. 2013 > + *

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-11-27 Thread Greg KH
On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: --- /dev/null +++ b/include/linux/genwqe/genwqe_card.h @@ -0,0 +1,547 @@ +#ifndef __GENWQE_CARD_H__ +#define __GENWQE_CARD_H__ + +/** + * IBM Accelerator Family 'GenWQE' + * + * (C) Copyright IBM Corp. 2013 + * + *

Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery

2013-11-27 Thread Greg KH
On Wed, Nov 06, 2013 at 01:45:38PM +0100, Frank Haverkamp wrote: +/* + * Flags for extended output (dbg_print) + * We define different levels of debugging for the appropriate unit. + */ +#define dbg_card 0x0001 +#define dbg_card_ddcb