Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-24 Thread One Thousand Gnomes
> I wasn't familiar with the alternatives logic before, so I had > to look it up. > Correct me if I'm wrong, but from what I gathered, the approach > that takes is especially suitable to fixup instructions that > are similar to each others but have slightly different properties > (the lock prefix

Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-24 Thread Stefan Kristiansson
On Wed, Jul 23, 2014 at 10:26:01PM +0100, One Thousand Gnomes wrote: > > +config OPENRISC_HAVE_INST_LWA_SWA > > + bool "Have instruction l.lwa and l.swa" > > + help > > + Select this if your implementation have l.lwa and l.swa atomic > > + instructions. > > + > > endmenu > > Please

Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-24 Thread Stefan Kristiansson
On Wed, Jul 23, 2014 at 10:26:01PM +0100, One Thousand Gnomes wrote: +config OPENRISC_HAVE_INST_LWA_SWA + bool Have instruction l.lwa and l.swa + help + Select this if your implementation have l.lwa and l.swa atomic + instructions. + endmenu Please do everyone a

Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-24 Thread One Thousand Gnomes
I wasn't familiar with the alternatives logic before, so I had to look it up. Correct me if I'm wrong, but from what I gathered, the approach that takes is especially suitable to fixup instructions that are similar to each others but have slightly different properties (the lock prefix to

Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-23 Thread One Thousand Gnomes
> +config OPENRISC_HAVE_INST_LWA_SWA > + bool "Have instruction l.lwa and l.swa" > + help > + Select this if your implementation have l.lwa and l.swa atomic > + instructions. > + > endmenu Please do everyone a favour - sort all these out at runtime, add an architectural

[PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-23 Thread Stefan Kristiansson
Not all OpenRISC cpus have support for the l.lwa and l.swa, this adds a config knob to opt them in and out. Signed-off-by: Stefan Kristiansson --- arch/openrisc/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig index

[PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-23 Thread Stefan Kristiansson
Not all OpenRISC cpus have support for the l.lwa and l.swa, this adds a config knob to opt them in and out. Signed-off-by: Stefan Kristiansson stefan.kristians...@saunalahti.fi --- arch/openrisc/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/openrisc/Kconfig

Re: [PATCH 1/6] openrisc: add Kconfig for l.lwa and l.swa atomic instructions

2014-07-23 Thread One Thousand Gnomes
+config OPENRISC_HAVE_INST_LWA_SWA + bool Have instruction l.lwa and l.swa + help + Select this if your implementation have l.lwa and l.swa atomic + instructions. + endmenu Please do everyone a favour - sort all these out at runtime, add an architectural feature bits