Re: [PATCH 1/7] binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

2020-05-06 Thread Eric W. Biederman
Greg Ungerer writes: > One small nit: Good point. > On 6/5/20 5:41 am, Eric W. Biederman wrote: >> In 2016 Linus moved install_exec_creds immediately after >> setup_new_exec, in binfmt_elf as a cleanup and as part of closing a >> potential information leak. >> >> Perform the same cleanup for

Re: [PATCH 1/7] binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

2020-05-06 Thread Greg Ungerer
One small nit: On 6/5/20 5:41 am, Eric W. Biederman wrote: In 2016 Linus moved install_exec_creds immediately after setup_new_exec, in binfmt_elf as a cleanup and as part of closing a potential information leak. Perform the same cleanup for the other binary formats. Different binary formats

Re: [PATCH 1/7] binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

2020-05-05 Thread Kees Cook
On Tue, May 05, 2020 at 02:41:01PM -0500, Eric W. Biederman wrote: > > In 2016 Linus moved install_exec_creds immediately after > setup_new_exec, in binfmt_elf as a cleanup and as part of closing a > potential information leak. > > Perform the same cleanup for the other binary formats. > >

[PATCH 1/7] binfmt: Move install_exec_creds after setup_new_exec to match binfmt_elf

2020-05-05 Thread Eric W. Biederman
In 2016 Linus moved install_exec_creds immediately after setup_new_exec, in binfmt_elf as a cleanup and as part of closing a potential information leak. Perform the same cleanup for the other binary formats. Different binary formats doing the same things the same way makes exec easier to